-
Notifications
You must be signed in to change notification settings - Fork 679
Bug 1143084 remove unused fonts from code base #3198
Bug 1143084 remove unused fonts from code base #3198
Conversation
Yay! Super excited to see this! This is the lion's share of the work and it looks solid. There's a little fine tuning to do. @davidyezsetz are you interested in doing that work too? Stuff like:
If not I can take over the branch and make them. It's probably just as fast to fix them as it is to report them. Again, really excited to see this PR. Thanks! |
Sure thing. 1,2,4 are clear, but what do you mean with changing buttons? |
For example the edit / remove / hide buttons on a demo detail page should match the edit button on wiki pages. Other examples of the button style can be found in places like the save button when editing a profile. It looks like the buttons are already inheriting and over-riding the default site button styles so hopefully this is just a matter of deleting more lines of code :) |
So we're talking about all instances of class="button" ? As long as I can grep something it shouldn't be a problem. |
It's more complicated than that. Maybe we should leave that for a future improvement. |
I was afraid this was the case. |
About moztt inclusion for Gaia demos: I don't see a single css file that is included in every demo. Should I create a moztt.css file and include it in all the demos? |
Editing the demos is complicated because they sit on the demos server. But that reminds me... I'm not sure they were picking up the font from the global style sheets (iframes don't inherit styles from their parents) if the font isn't being included directly in any of those files right now it's probably never been displaying. I'll talk to the content team and see if they have any thoughts (or might be willing to do the work of editing the demos). |
I'm going to file a separate bug for the moztt stuff too. We won't be breaking anything with this PR that isn't already broken. |
Great. Baring mistakes in my last two commits this should be complete then. |
👍 This is ready to go. |
Superseded by #3202 which uses the same changes but prepends bug numbers to the commit messages. |
Thanks for doing that @openjck I really wanted to merge this one today :) |
https://bugzilla.mozilla.org/show_bug.cgi?id=1143084