Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Bug 1143084 remove unused fonts from code base #3198

Conversation

davidyezsetz
Copy link
Contributor

@stephaniehobson
Copy link
Contributor

Yay! Super excited to see this! This is the lion's share of the work and it looks solid.

There's a little fine tuning to do. @davidyezsetz are you interested in doing that work too?

Stuff like:

  • setting letter spacing on .demo-title to 0
  • vertically centering and uppercasing .gallery-head .count

If not I can take over the branch and make them. It's probably just as fast to fix them as it is to report them.

Again, really excited to see this PR. Thanks!

@davidyezsetz
Copy link
Contributor Author

Sure thing. 1,2,4 are clear, but what do you mean with changing buttons?

@stephaniehobson
Copy link
Contributor

For example the edit / remove / hide buttons on a demo detail page should match the edit button on wiki pages. Other examples of the button style can be found in places like the save button when editing a profile.

It looks like the buttons are already inheriting and over-riding the default site button styles so hopefully this is just a matter of deleting more lines of code :)

@davidyezsetz
Copy link
Contributor Author

So we're talking about all instances of class="button" ? As long as I can grep something it shouldn't be a problem.

@stephaniehobson
Copy link
Contributor

It's more complicated than that. Maybe we should leave that for a future improvement.

@davidyezsetz
Copy link
Contributor Author

I was afraid this was the case.
I think there needs to be a bit of groundwork i.e. digging through the pages to find all implementation of buttons that should look alike and listing them like this. Then a designer can pick one and it can be implemented.
I will finish your other 3 points in the meantime, so this can be merged in.

@davidyezsetz
Copy link
Contributor Author

About moztt inclusion for Gaia demos: I don't see a single css file that is included in every demo. Should I create a moztt.css file and include it in all the demos?

@stephaniehobson
Copy link
Contributor

Editing the demos is complicated because they sit on the demos server. But that reminds me... I'm not sure they were picking up the font from the global style sheets (iframes don't inherit styles from their parents) if the font isn't being included directly in any of those files right now it's probably never been displaying. I'll talk to the content team and see if they have any thoughts (or might be willing to do the work of editing the demos).

@stephaniehobson
Copy link
Contributor

I'm going to file a separate bug for the moztt stuff too. We won't be breaking anything with this PR that isn't already broken.

@davidyezsetz
Copy link
Contributor Author

Great. Baring mistakes in my last two commits this should be complete then.

@stephaniehobson
Copy link
Contributor

👍 This is ready to go.

@openjck
Copy link
Contributor

openjck commented Apr 27, 2015

Superseded by #3202 which uses the same changes but prepends bug numbers to the commit messages.

@openjck openjck closed this Apr 27, 2015
@stephaniehobson
Copy link
Contributor

Thanks for doing that @openjck I really wanted to merge this one today :)

@davidyezsetz davidyezsetz deleted the Bug-1143084-Remove-unused-fonts-from-code-base branch April 27, 2015 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants