Update lmdb to latest version and other goodies #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great; I'm super-psyched that you've automated the bindings generation.
I looked at a couple of the failing Windows builds, and they fail with errors like:
cargo:warning=cl : Command line error D8021 : invalid numeric argument '/Wno-unused-parameter'
Setting the flag via https://docs.rs/cc/1.0.4/cc/struct.Build.html#method.flag_if_supported should resolve that.
I'm unsure about the errors on macOS, but it looks like they only occur with Rust 1.30, so perhaps a dependency requires a newer version. Maybe we can simply drop support for that version of Rust?
.file(lmdb.join("mdb.c")) | ||
.file(lmdb.join("midl.c")) | ||
// https://github.com/LMDB/lmdb/blob/LMDB_0.9.21/libraries/liblmdb/Makefile#L25 | ||
.opt_level(2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think we need to install libclang on windows:
|
7e8588a
to
edd7b2e
Compare
Ah, indeed, according to https://rust-lang.github.io/rust-bindgen/requirements.html. And the LLVM installer for Windows is GUI-based, which'd make it hard to install in CI. Perhaps instead of regenerating bindings at build time we should include the generated bindings in this changset? |
edd7b2e
to
317168b
Compare
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Fixes #54 Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
317168b
to
6bd3798
Compare
This PR: