This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
Fix Bug 880900 - Add CSRF Token support to SSO requests #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,6 +183,9 @@ | |||
| type: 'POST', | |||
| url: '/persona/verify', | |||
| data: {assertion: assertion}, | |||
| beforeSend: function (request) { | |||
| request.setRequestHeader("x-csrf-token", document.querySelector("meta[name='sso-csrf-token']").content); | |||
There was a problem hiding this comment.
From the express docs, use X-CSRF-Token: http://expressjs.com/api.html#csrf
There was a problem hiding this comment.
Also, change the meta tag to just csrf-token; it's not being used just for sso
There was a problem hiding this comment.
Also also, this will fail if the page does not have that particular meta element on the page with a TypeError: document.querySelector(...) is null.
Add an if check, and I think this is ready to go.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=880900