Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1772451 - Combine and refactor search and activity stream aggregate tables #358

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Bug 1772451 - Combine and refactor search and activity stream aggregate tables #358

merged 3 commits into from
Jun 9, 2022

Conversation

ANich
Copy link
Contributor

@ANich ANich commented Jun 8, 2022 •
edited

RE: 1772451 - A few optimizations for search and activity stream aggregate tables:

  1. Combines a few queries into a single aggregate.
  2. Makes aggregates incremental so we don't scan all of history for each build.
  3. Removes non-daily aggregates, these don't get redirected to due to always_filter on date's in dimension groups prevent aggregate tables at other date levels. lookml-generator#388

@ANich ANich changed the title Prune pdts Combine and refactor search and activity stream aggregate tables Jun 9, 2022
@ANich ANich marked this pull request as ready for review June 9, 2022 20:28
@ANich ANich changed the title Combine and refactor search and activity stream aggregate tables Bug 1772451 - Combine and refactor search and activity stream aggregate tables Jun 9, 2022
@ANich ANich merged commit 189c957 into main Jun 9, 2022
@ANich ANich deleted the prune_pdts branch June 9, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marlene-M-Hirose Marlene-M-Hirose Marlene-M-Hirose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ANich @Marlene-M-Hirose