Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

updating jshintrc and jshintignore #41

Closed
wants to merge 1 commit into from

Conversation

pdehaan
Copy link
Contributor

@pdehaan pdehaan commented Aug 26, 2014

@pdehaan
Copy link
Contributor Author

pdehaan commented Aug 26, 2014

We still have a few errors, and i'm not sure how to proceed:

$ make lint
content/js/webapp.js: line 26, col 7, 'router' is defined but never used.
content/js/webapp.js: line 85, col 7, 'ConversationHeader' is defined but never used.
content/js/webapp.js: line 120, col 7, 'ConversationFooter' is defined but never used.
content/js/webapp.js: line 88, col 11, 'conversationUrl' is defined but never used.
content/js/webapp.js: line 90, col 11, 'urlCreationDateClasses' is defined but never used.
content/js/webapp.js: line 97, col 11, 'callUrlCreationDateString' is defined but never used.
content/js/webapp.js: line 224, col 11, 'tosHTML' is defined but never used.
content/js/webapp.js: line 231, col 11, 'btnClassStartCall' is defined but never used.
content/js/webapp.js: line 234, col 11, 'dropdownMenuClasses' is defined but never used.

content/shared/js/views.js: line 466, col 33, Expected '===' and instead saw '=='.
content/shared/js/views.js: line 468, col 22, Expected '===' and instead saw '=='.

content/shared/js/websocket.js: line 46, col 4, Unnecessary semicolon.
content/shared/js/websocket.js: line 58, col 25, 'Promise' is not defined.

test/shared/views_test.js: line 17, col 7, 'getReactElementByClass' is defined but never used.

test/standalone/standalone_client_test.js: line 97, col 9, Missing semicolon.
test/standalone/standalone_client_test.js: line 44, col 19, 'fakeServerErrorDescription' is defined but never used.
test/standalone/standalone_client_test.js: line 5, col 1, 'hawk' is defined but never used.

test/standalone/webapp_test.js: line 145, col 29, 'Promise' is not defined.
test/standalone/webapp_test.js: line 187, col 29, 'Promise' is not defined.
test/standalone/webapp_test.js: line 205, col 13, 'done' is not defined.
test/standalone/webapp_test.js: line 512, col 11, 'requestCallUrlInfo' is defined but never used.
test/standalone/webapp_test.js: line 607, col 31, 'StandaloneClient' is defined but never used.

22 errors
make: *** [lint] Error 2

I don't know what a "/shared/" directory is. Is that something we can edit, or should I add those paths to the .jshintignore.

@Standard8
Copy link
Member

Sorry, we never got to this when it was originally proposed. We're just landing eslint integration in https://bugzilla.mozilla.org/show_bug.cgi?id=999737 so we'll be able to start fixing some of these if they are still an issue.

@Standard8 Standard8 closed this Apr 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants