Update eslint-plugin-react to version 5.2.2 🚀 #524
Conversation
|
Autolander could not find a bug number in your pull request title. All pull requests should be in the format of: Bug [number] - [description]. |
Standard8
force-pushed
the
greenkeeper-eslint-plugin-react-5.2.2
branch
2 times, most recently
from
32ea2ec
to
dfae93b
Compare
|
@Mardak What do you think about the bits that eslint complains about here? A bug in the plugin? |
Standard8
force-pushed
the
greenkeeper-eslint-plugin-react-5.2.2
branch
4 times, most recently
from
70214da
to
b148185
Compare
Standard8
force-pushed
the
greenkeeper-eslint-plugin-react-5.2.2
branch
from
b148185
to
04c2726
Compare
|
The change that caused the eslint test to fail: jsx-eslint/eslint-plugin-react#474 where previously it didn't look at the expressions. The jsx-no-bind rule is there to prevent each |
Mardak
force-pushed
the
greenkeeper-eslint-plugin-react-5.2.2
branch
from
22000f8
to
2e82aa8
Compare
| @@ -342,7 +342,7 @@ loop.roomViews = (function(mozL10n) { | |||
| localPosterUrl={this.props.localPosterUrl} | |||
| localSrcMediaElement={this.state.localSrcMediaElement} | |||
| localVideoMuted={this.state.videoMuted} | |||
| matchMedia={this.state.matchMedia || window.matchMedia.bind(window)} | |||
| matchMedia={this.state.matchMedia || window.matchMedia} | |||
There was a problem hiding this comment.
So now you've done the nice changes, I'm not sure that matchMedia is actually used any more - looks like we dropped it at some stage. Maybe just drop it all now?
There was a problem hiding this comment.
Ok, this is actually used on master.
|
r=Standard8 |
Hello lovely humans,
eslint-plugin-react just published its new version 5.2.2.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint-plugin-react.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
Fixed
jsx-no-bindcrash (#641)The new version differs by 35 commits .
46c8008Update CHANGELOG and bump version281faf0Fix jsx-no-bind crash (fixes #641)d6d0d8aUpdate CHANGELOG and bump versionef406faFix jsx-pascal-case for JSXMemberExpressions (fixes #637)e626566Update CHANGELOG and bump version67053d9Add missing no-comment-textnodes rule to README698d7e5Update dependenciese341dfaFix prop-types crash when destructuring props with spread onlycd5ef2bIntegrate jsx-ast-utils7586915Fix jsx-curly-spacing alternative optionfaaa823Add support for ES7 bind operator to jsx-handler-names (fixes #630)4418534Add ignore option to no-unknown-property rule2508576Update README to add react/ prefix to rule names0aeebafFix sort-comp crash on spread operator (fixes #624)aa359fbAdd no-comment-textnodes ruleThere are 35 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade