-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added localization test #3
Conversation
When I ran this through Jenkins, I got:
Do we know where the lower-case "en-us" is coming from? |
Ah, that comes from the app itself: We're discussing in #webdev as to whether we should do a case-insensitive string-compare in this test. |
From @jsocol: "stephend: well, the behavior of Mozilla sites is to have one canonical URL and to capitalize the US, so en-us -> en-US is correct, and that's what the test should assert |
Fixed. Done it fast before going to sleep, so please check if it works for you now @stephendonner . Thanks |
Thx; ran it through the proverbial grinder (Jenkins), and it's fine now :-) |
|
||
@property | ||
def locales_count(self): | ||
locator = (self.language_locator[0], '%s option' % self.language_locator[1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to avoid splitting the locator tuple in this way. You could use return len(self.selenium.find_element(*self._language_locator).find_elements(By.TAG_NAME, 'option'))
, or create a new locator for languages.
Selecting a different locale/language should go to that page, and have /[$locale/] in the URL