Merge pull request #389 from jgmize/rm-home-images-test

Remove brittle home page images test
mozilla · Mar 13, 2015 · 453c30d · 453c30d
2 parents 2f9fb5e + 82a1b8b
commit 453c30d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 20 deletions.
diff --git a/pages/desktop/home.py b/pages/desktop/home.py
@@ -86,16 +86,6 @@ def go_to_page(self):
         },
     ]
 
-    images_list = [
-        {
-            'locator': (By.CSS_SELECTOR, '.primary img'),
-            'img_name_suffix': 'firefox-logo.*.png',
-        }, {
-            'locator': (By.CSS_SELECTOR, '#firefox-promo-link img'),
-            'img_name_suffix': 'firefox-logo-wordmark-white.*.png',
-        }
-    ]
-
     _sign_up_form_locator = (By.ID, 'mozorg-newsletter-form')
 
     sign_up_form_link_list = [

diff --git a/tests/test_home.py b/tests/test_home.py
@@ -71,16 +71,6 @@ def test_footer_links_are_valid(self, mozwebqa):
                 bad_urls.append('%s is not a valid url - status code: %s.' % (url, response_code))
         Assert.equal(0, len(bad_urls), '%s bad links found: ' % len(bad_urls) + ', '.join(bad_urls))
 
-    @pytest.mark.nondestructive
-    def test_images_are_visible(self, mozwebqa):
-        home_page = HomePage(mozwebqa)
-        home_page.go_to_page()
-        bad_images = []
-        for image in home_page.images_list:
-            if not home_page.is_element_visible(*image.get('locator')):
-                bad_images.append('The image at %s is not visible' % image.get('locator')[1:])
-        Assert.equal(0, len(bad_images), '%s bad images found: ' % len(bad_images) + ', '.join(bad_images))
-
     @pytest.mark.nondestructive
     def test_image_srcs_are_correct(self, mozwebqa):
         home_page = HomePage(mozwebqa)