Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

Bug 906176: Fix tests for bedrock move to staticfiles. #380

Merged
merged 1 commit into from Feb 11, 2015

Conversation

pmclanahan
Copy link

Also django-pipeline and Whitenoise. All static files
(css, js, images, fonts, etc.) will now be named with
the md5 hash of the file contents (e.g. old-logo.deadbeef123.png)
thus making it impossible for this suite to know the full file
name. This switches those tests to use fnmatch from the
Python stdlib.

Also django-pipeline and Whitenoise. All static files
(css, js, images, fonts, etc.) will now be named with
the md5 hash of the file contents (e.g. old-logo.deadbeef123.png)
thus making it impossible for this suite to know the full file
name. This switches those tests to use fnmatch from the
Python stdlib.
@pmclanahan
Copy link
Author

The changes for bedrock that necessitate these changes are currently on demo4. Can we run the demo4 suite using this code before this is merged?

@pmclanahan
Copy link
Author

@stephendonner @bobsilverberg ?

@stephendonner
Copy link
Contributor

I've set up a Jenkins job and it's passed (w00t): http://selenium.qa.mtv2.mozilla.com:8080/job/mozilla.org.demo4.pmac-pull.saucelabs/1/

@stephendonner
Copy link
Contributor

Tagging @rbillings for the r?

@stephendonner
Copy link
Contributor

NOTE: this depends on mozilla/bedrock#2672, which needs to go first, as it currently stands, so let's not merge until then. Thanks!

@pmclanahan
Copy link
Author

WOOT! Thanks @stephendonner 🍰

@rbillings
Copy link
Collaborator

The fundamental changes look good to me. The smallest of nits would be to add a space between the license and the fnmatch import on the test_dnt/test_home/test_product pages.

I'm also curious why none of the .pngs were updated from the _operators_image_list - line 154 on partners.py?

@pmclanahan
Copy link
Author

I'm also curious why none of the .pngs were updated from the _operators_image_list - line 154 on partners.py?

I believe those files aren't actually used anywhere. Could be a cleanup task, but I wasn't sure.

jgmize added a commit that referenced this pull request Feb 11, 2015
Bug 906176: Fix tests for bedrock move to staticfiles.
@jgmize jgmize merged commit cd91883 into mozilla:master Feb 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants