Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Change require statements to match the new SDK module layout and update the SDK to 1.13.2 #163

Closed
wants to merge 3 commits into from

3 participants

@KWierso

This should let #162 work.

With this change, I no longer see the error about memory.js.

@KWierso

Added the commit to update the SDK to 1.13.2 here to see if Travis likes it any better. Seems like it does.

@whimboo
Owner

As discussed on IRC the only change necessary for now is the require line for local modules. So I'm going with the minimal change for Memchaser 0.5.2 and keep this pull in the backlog for 0.5.3. Once we are safe in using SDK 1.13 we can do this invasive module update.

@whimboo
Owner

I would like to have this in 0.6. @KWierso would you mind updating the pull to the lastest master?

@whimboo
Owner

Hi @KWierso. As I have asked 2 months ago, would you be interested to update your pull to the latest master? I would like to see this in our next 0.6 release. Thanks.

@whimboo whimboo referenced this pull request
Closed

Update Add-on SDK to 1.14 #167

@KWierso

@whimboo I'll try to get to it sometime this week, but if I don't do it this week, you might be better off just taking it over yourself.

@xabolcs
Collaborator

Can I contribute here?

@whimboo
Owner

Absolutely! I would appreciate your help here.

@xabolcs
Collaborator

Absolutely! I would appreciate your help here.

Placeholder (only a mirror of this) pull request opened.

@whimboo
Owner

Closing this pull in favor of pull #174.

@whimboo whimboo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 19, 2013
  1. Fix up more require statements

    Wes Kocher authored
  2. Update bundled version of the Addon SDK to 1.13.2

    Wes Kocher authored
This page is out of date. Refresh to see the latest.
2  addon-sdk
@@ -1 +1 @@
-Subproject commit 176d82da5b7de5c27c8fd50bc9fa7b053eda5412
+Subproject commit 42893f920fb6c5598a0b5f524e838fd3fddb3848
View
8 extension/lib/garbage-collector.js
@@ -5,11 +5,11 @@
"use strict";
const { Cc, Ci, Cu } = require("chrome");
-const { EventEmitter } = require("api-utils/events");
-const prefs = require("api-utils/preferences-service");
-const unload = require("api-utils/unload");
+const { EventEmitter } = require("sdk/deprecated/events");
+const prefs = require("sdk/preferences/service");
+const unload = require("sdk/system/unload");
-const config = require("config");
+const config = require("./config");
Cu.import('resource://gre/modules/Services.jsm');
View
2  extension/lib/logger.js
@@ -3,7 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
const { components, Cc, Ci, Cu } = require("chrome");
-const unload = require("api-utils/unload");
+const unload = require("sdk/system/unload");
Cu.import('resource://gre/modules/NetUtil.jsm');
Cu.import('resource://gre/modules/Services.jsm');
View
16 extension/lib/main.js
@@ -5,16 +5,16 @@
"use strict";
const { Cc, Ci, Cu, CC } = require("chrome");
-const events = require("events");
-const prefs = require("api-utils/preferences-service");
+const events = require("sdk/deprecated/events");
+const prefs = require("sdk/preferences/service");
const self = require("self");
-const simple_prefs = require("simple-prefs");
-const widgets = require("widget");
+const simple_prefs = require("sdk/simple-prefs");
+const widgets = require("sdk/widget");
-const config = require("config");
-const garbage_collector = require("garbage-collector");
-const { Logger } = require("logger");
-var memory = require("memory");
+const config = require("./config");
+const garbage_collector = require("./garbage-collector");
+const { Logger } = require("./logger");
+var memory = require("./memory");
Cu.import('resource://gre/modules/Services.jsm');
View
8 extension/lib/memory.js
@@ -5,11 +5,11 @@
"use strict";
const { Cc, Ci, Cu } = require("chrome");
-const { EventEmitter } = require("api-utils/events");
-const prefs = require("api-utils/preferences-service");
+const { EventEmitter } = require("sdk/deprecated/events");
+const prefs = require("sdk/preferences/service");
const self = require("self");
-const timer = require("api-utils/timer");
-const unload = require("api-utils/unload");
+const timer = require("sdk/timers");
+const unload = require("sdk/system/unload");
const config = require("config");
Something went wrong with that request. Please try again.