Skip to content
This repository has been archived by the owner on Oct 18, 2018. It is now read-only.

Change require statements to match the new SDK module layout and update the SDK to 1.13.2 #163

Closed
wants to merge 3 commits into from

Conversation

KWierso
Copy link

@KWierso KWierso commented Feb 19, 2013

This should let #162 work.

With this change, I no longer see the error about memory.js.

@KWierso
Copy link
Author

KWierso commented Feb 19, 2013

Added the commit to update the SDK to 1.13.2 here to see if Travis likes it any better. Seems like it does.

@whimboo
Copy link
Contributor

whimboo commented Feb 19, 2013

As discussed on IRC the only change necessary for now is the require line for local modules. So I'm going with the minimal change for Memchaser 0.5.2 and keep this pull in the backlog for 0.5.3. Once we are safe in using SDK 1.13 we can do this invasive module update.

@whimboo
Copy link
Contributor

whimboo commented Feb 19, 2013

I would like to have this in 0.6. @KWierso would you mind updating the pull to the lastest master?

@whimboo
Copy link
Contributor

whimboo commented Apr 15, 2013

Hi @KWierso. As I have asked 2 months ago, would you be interested to update your pull to the latest master? I would like to see this in our next 0.6 release. Thanks.

@KWierso
Copy link
Author

KWierso commented Apr 15, 2013

@whimboo I'll try to get to it sometime this week, but if I don't do it this week, you might be better off just taking it over yourself.

@xabolcs
Copy link
Collaborator

xabolcs commented May 24, 2013

Can I contribute here?

@whimboo
Copy link
Contributor

whimboo commented May 26, 2013

Absolutely! I would appreciate your help here.

@xabolcs
Copy link
Collaborator

xabolcs commented May 27, 2013

Absolutely! I would appreciate your help here.

Placeholder (only a mirror of this) pull request opened.

@whimboo
Copy link
Contributor

whimboo commented May 29, 2013

Closing this pull in favor of pull #174.

@whimboo whimboo closed this May 29, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants