mozdownload should grab candidate builds from candidates/ and not nightly/

[whimboo]

We got informed by @bhearsum that we should not grab candidate builds for Firefox from the firefox/nightly/ folder, but from firefox/candidates.

[jayrajput]

I looked at the code and found that I can fix it in ReleaseCandidateScrapper::candidate_build_list_regex.

Question:

• What about other applications (b2g and thunderbird)? Application b2g does not have any candidate folder, thunderbird has one.

Since it is application specific, I can either do these two:

• Add a mapping b/w application (b2g, firefox, thunderbird) and candidate build location folder in the ReleaseCandidateScrapper.
• Check if candidate folder exists, if yes use it else fallback on the nightly folder. I will need to figure out someway to check if the directory exists

Let me know and I can make changes in the fork I created for #22 (Add a bash-completion script).

[whimboo]

What about other applications (b2g and thunderbird)? Application b2g does not have any candidate folder, thunderbird has one.

We do not support downloading of b2g builds yet. That is still an open issue, where we already have a PR which needs to be done. So for Firefox and Thunderbird it should be fine.

@bhearsum, just to make sure... we can access the candidate builds in that folder at the time when they have been created? Means they will be available at the same time in candidates/ as in /nightly?

[jayrajput]

I have updated the candidate_build_list_regex of the ReleaseCandidateScraper class to use candidates in place of nightly. The tests are also updated and all passed. I also tried manually downloading candidate build for v30.0 and it worked fine.

[jayrajput]

code is available for review. Please see the pull request.

[whimboo]

The PR on issue #221 has been landed. Thanks @jayrajput for working on it!