Add consistent build number error notification for scrapers (#121) #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
requested changes
May 6, 2024
…ndling (mozilla#121) - use exact same error message
|
All error messages are the same now :) @whimboo |
|
Interesting build errors from 3.8 and 3.12 on Windows |
|
Your patch shouldn't have caused those failures. In the past we already had those issues but these were mostly for tinderbox builds and too huge folders to scrape. Not sure what these are right now. I've retriggered the failing jobs. Lets see if the failures remain. |
whimboo
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #121 - Add consistent build number error notification for daily, Tinderbox, and release candidate scrapers @whimboo
Test cases added