-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #118 - Maintain schema compatibility for changed probe type #119
Conversation
This is done on a case-by-case basis. In particular, this adds a copy of the `installation.timestamp` metric as a string and a datetime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acmiyaguchi the recent run seems to have fixed these. We don't necessarily need to merge this now, okay with you to close?
Yep, seems reasonable to me. My only question is, how did it fix itself? |
Re-opening, because datetimes are the metric that we want to be reporting. |
Here's a clean diff that works as expected. There isn't an obvious way to check against the repo url in the GleanPing object, so I enumerated the repo names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #118. This is done on a case-by-case basis. In particular, this adds a copy of the
installation.timestamp
metric as a string and a datetime.This diff shows the change from master: mozilla-services/mozilla-pipeline-schemas@9c966c1