Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #118 - Maintain schema compatibility for changed probe type #119

Merged
merged 6 commits into from
Mar 10, 2020

Conversation

acmiyaguchi
Copy link
Contributor

@acmiyaguchi acmiyaguchi commented Mar 9, 2020

Fixes #118. This is done on a case-by-case basis. In particular, this adds a copy of the installation.timestamp metric as a string and a datetime.

export MPS_SSH_KEY_BASE64=$(cat ~/.ssh/id_rsa | base64)

git checkout master
make build && make run

git checkout type_change
make build && make run

This diff shows the change from master: mozilla-services/mozilla-pipeline-schemas@9c966c1

This is done on a case-by-case basis. In particular, this adds a copy of
the `installation.timestamp` metric as a string and a datetime.
@acmiyaguchi acmiyaguchi marked this pull request as ready for review March 9, 2020 22:02
Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acmiyaguchi the recent run seems to have fixed these. We don't necessarily need to merge this now, okay with you to close?

@acmiyaguchi
Copy link
Contributor Author

Yep, seems reasonable to me. My only question is, how did it fix itself?

@acmiyaguchi
Copy link
Contributor Author

Re-opening, because datetimes are the metric that we want to be reporting.

@acmiyaguchi acmiyaguchi reopened this Mar 10, 2020
@acmiyaguchi
Copy link
Contributor Author

Here's a clean diff that works as expected. There isn't an obvious way to check against the repo url in the GleanPing object, so I enumerated the repo names.

mozilla-services/mozilla-pipeline-schemas@8eb8024

Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbertsch fbertsch merged commit 862ac6f into master Mar 10, 2020
@kik-kik kik-kik deleted the type_change branch November 23, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants