Bug 1289823 - Flexible action task

[imbstack]

@armenzg: This should be updated here and pulled into pulse_actions before https://reviewboard.mozilla.org/r/96072 lands. It will allow it to work with both styles of action.yml until the old-style is completely gone at some point. I have backfill logic in-tree ready to go once this is all merged in if this is a good direction to go in.

Heads up: @djmitche

The added lines in test/helpers.py was just to get tox to pass locally. I assume some lint library was updated at some point or something.

---

This change is 

[armenzg]

This lgtm. Just address the question wrt the optional parameter and we can merge and land after that.
I can take care of bumping the mozci version and we need pulse_actions to use this new version.

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

mozci/taskcluster/tc.py, line 112 at r1 (raw file):

        # Downloading the YAML file for action tasks
        # Action Tasks will be used to schedule the Task Labels in the parameters
        action_task = get_artifact_for_task_id(task_id=decision_task_id,

We've changed the signature to make decision_task_id optional, however, in this line we still require it at all times.
Could you please keep decision_task_id as mandatory? Unless I'm missing something.

---

Comments from Reviewable

[djmitche]

Will one of the action_args be "action" or some such thing that says which action to perform?

[imbstack]

@djmitche: Yep, that's the plan!