[bug 1129848] Do not use the same ID multiple times.

mozilla · Mar 16, 2016 · c72dca1 · c72dca1
1 parent 9b1bded
commit c72dca1
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 14 deletions.
diff --git a/mozillians/jinja2/phonebook/includes/profile_edit_accounts.html b/mozillians/jinja2/phonebook/includes/profile_edit_accounts.html
@@ -45,7 +45,7 @@
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="accounts_section">{{ _('Update External Accounts') }}</button>
+        <button class="btn btn-primary" id="form-submit-accounts" type="submit" name="accounts_section">{{ _('Update External Accounts') }}</button>
       </div>
     </div>
 
@@ -64,7 +64,7 @@
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="irc_section">{{ _('Update IRC information') }}</button>
+        <button class="btn btn-primary" id="form-submit-irc" type="submit" name="irc_section">{{ _('Update IRC information') }}</button>
       </div>
     </div>
   </div>

diff --git a/mozillians/jinja2/phonebook/includes/profile_edit_basic.html b/mozillians/jinja2/phonebook/includes/profile_edit_basic.html
@@ -80,7 +80,7 @@
       </div>
 
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="basic_section">{{ _('Update Information') }}</button>
+        <button class="btn btn-primary" id="form-submit-basic" type="submit" name="basic_section">{{ _('Update Information') }}</button>
       </div>
     </div>
   </form>
@@ -139,7 +139,7 @@
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="email_section">{{ _('Update Emails') }}</button>
+        <button class="btn btn-primary" id="form-submit-email" type="submit" name="email_section">{{ _('Update Emails') }}</button>
       </div>
     </div>
   </form>
@@ -176,7 +176,7 @@
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="skills_section">{{ _('Update Skills') }}</button>
+        <button class="btn btn-primary" id="form-submit-skills" type="submit" name="skills_section">{{ _('Update Skills') }}</button>
       </div>
     </div>
   </form>
@@ -223,7 +223,7 @@
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="languages_section">{{ _('Update Languages') }}</button>
+        <button class="btn btn-primary" id="form-submit-langauge" type="submit" name="languages_section">{{ _('Update Languages') }}</button>
       </div>
     </div>
   </form>

diff --git a/mozillians/jinja2/phonebook/includes/profile_edit_developer.html b/mozillians/jinja2/phonebook/includes/profile_edit_developer.html
@@ -36,7 +36,9 @@ <h4>{{ _('Privacy') }}</h4>
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="developer_section">{{ _('Update Privacy Settings') }}</button>
+        <button class="btn btn-primary" id="form-submit-developer" type="submit"
+                name="developer_section">{{ _('Update Privacy Settings') }}
+        </button>
       </div>
     </div>
     {% if user.userprofile.is_vouched %}

diff --git a/mozillians/jinja2/phonebook/includes/profile_edit_groups.html b/mozillians/jinja2/phonebook/includes/profile_edit_groups.html
@@ -48,7 +48,7 @@
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="groups_section">{{ _('Update Groups') }}</button>
+        <button class="btn btn-primary" id="form-submit-groups" type="submit" name="groups_section">{{ _('Update Groups') }}</button>
       </div>
     </div>
   </div>

diff --git a/mozillians/jinja2/phonebook/includes/profile_edit_location.html b/mozillians/jinja2/phonebook/includes/profile_edit_location.html
@@ -117,7 +117,9 @@
         {{ location_form.lng }}
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="location_section">{{ _('Update Location') }}</button>
+        <button class="btn btn-primary" id="form-submit-location" type="submit"
+                name="location_section">{{ _('Update Location') }}
+        </button>
       </div>
     </div>
   </div>

diff --git a/mozillians/jinja2/phonebook/includes/profile_edit_registration.html b/mozillians/jinja2/phonebook/includes/profile_edit_registration.html
@@ -191,7 +191,9 @@
       </div>
     </div>
     <div class="panel-footer">
-      <button class="btn btn-primary" id="form-submit-top" type="submit" name="registration_section">{{ _('Create Profile') }}</button>
+      <button class="btn btn-primary" id="form-submit-registration" type="submit"
+              name="registration_section">{{ _('Create Profile') }}
+      </button>
     </div>
   </div>
 </form>
diff --git a/mozillians/jinja2/phonebook/includes/profile_edit_you.html b/mozillians/jinja2/phonebook/includes/profile_edit_you.html
@@ -38,7 +38,9 @@
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="contribution_section">{{ _('Update Contributions') }}</button>
+        <button class="btn btn-primary" id="form-submit-contribution" type="submit"
+                name="contribution_section">{{ _('Update Contributions') }}
+        </button>
       </div>
     </div>
   </form>
@@ -65,7 +67,8 @@
               <div class="fitted">
                 <h4>
                   {{ _('Fitted') }}
-                  <span title="{{ _('A fitted-cut tshirt has a curved side hem which comes in at the waist and goes out at the upper and lower ends. Also known as women\'s.') }}" class="glyphicon glyphicon-info-sign info" aria-hidden="true"></span>
+                  <span title="{{ _('A fitted-cut tshirt has a curved side hem which comes in at the waist and goes out at the upper and lower ends. Also known as women\'s.') }}"
+                        class="glyphicon glyphicon-info-sign info" aria-hidden="true"></span>
                 </h4>
                 {% for t_select in t_choices[1:7] %}
                   <div class="tshirt-option">
@@ -78,7 +81,8 @@ <h4>
               <div class="straightcut">
                 <h4>
                   {{ _('Straight-cut') }}
-                  <span title="{{ _('A straight-cut shirt has wide shoulders and a body which is almost square. Often known as men\'s or unisex.') }}" class="glyphicon glyphicon-info-sign info" aria-hidden="true"></span>
+                  <span title="{{ _('A straight-cut shirt has wide shoulders and a body which is almost square. Often known as men\'s or unisex.') }}"
+                        class="glyphicon glyphicon-info-sign info" aria-hidden="true"></span>
                 </h4>
                 {% for t_select in t_choices[7:14] %}
                   <div class="tshirt-option">
@@ -95,7 +99,9 @@ <h4>
         </fieldset>
       </div>
       <div class="panel-footer">
-        <button class="btn btn-primary" id="form-submit-top" type="submit" name="tshirt_section">{{ _('Update T-shirt size') }}</button>
+        <button class="btn btn-primary" id="form-submit-tshirt" type="submit"
+                name="tshirt_section">{{ _('Update T-shirt size') }}
+        </button>
       </div>
     </div>
   </form>