This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Bug 938184 - Don't allow creating groups while editing user profile #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the changes for curated groups is that groups will only be creatable from the groups list page, so only allow people editing their profiles to select groups that already exist. The tag-it library that was being used to implement the groups selection could not easily be configured or modified to prevent users from selecting non-existent items, so the groups field was changed to use django-selectable. Styling was added to make the django-selectable field look like the current tag-it fields, which are still being used for e.g. skills and languages.
|
I just noticed helpers.py/stringify_groups is probably not needed anymore. I'll remove it. |
|
It turned out that stringify_groups is still used by skills. But I did spot some other unused code in forms.py and removed that. |
| @@ -161,18 +170,11 @@ def clean_groups(self): | |||
| consistent. | |||
|
|
|||
| """ | |||
| if not re.match(r'^[a-zA-Z0-9 .:,-]*$', self.cleaned_data['groups']): | |||
| raise forms.ValidationError(_(u'Groups can only contain ' | |||
There was a problem hiding this comment.
hmm, is it an intentional part of the new spec that groups are no longer restricted to alphanumeric ascii?
There was a problem hiding this comment.
The autocomplete widget only allows existing groups to be selected, so we can't affect what names can be given to groups here.
We'll want to be sure the new page for creating curated groups does whatever validation of group names is needed, though.
|
merged manually into curatedgroups: ef9d0bd Thanks! Closing this out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the changes for curated groups is that groups will only be
creatable from the groups list page, so only allow people editing
their profiles to select groups that already exist.
The tag-it library that was being used to implement the groups
selection could not easily be configured or modified to prevent
users from selecting non-existent items, so the groups field
was changed to use django-selectable. Styling was added to make
the django-selectable field look like the current tag-it fields,
which are still being used for e.g. skills and languages.