This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Bug 938184 - User cannot join or leave groups while editing profile #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This goes beyond the previous commit for this bug, which only prevented creating new groups while editing the profile. This changes the groups control on the edit profile page to just a list of links to the groups the user belongs to. Fix bug 938184
| @@ -214,7 +214,6 @@ def delete(request): | |||
|
|
|||
| @allow_public | |||
| def search(request): | |||
| num_pages = 0 | |||
There was a problem hiding this comment.
This variable is used below on https://github.com/caktus/mozillians/blob/f708698f85a420e5865dd2d7667ff032910dca47/mozillians/phonebook/views.py#L245
There was a problem hiding this comment.
Line 245 is paginator.num_pages and this is num_pages. Unless there's something too subtle for me going on here...
There was a problem hiding this comment.
er, yeah, you're right. Nevermind!
|
r+wc |
Sancus
added a commit
that referenced
this pull request
Dec 13, 2013
…on_profile_edit Bug 938184 - User cannot join or leave groups while editing profile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes beyond the previous commit for this bug, which only
prevented creating new groups while editing the profile. This
changes the groups control on the edit profile page to just
a list of links to the groups the user belongs to.
Fix bug 938184