Update logic for is_the_current_page to address titles on dev

[bobsilverberg]

This addresses a number of failures on moztrap.dev. It looks like the page titles have changed to be labelled Moztrap-Dev, instead of just Moztrap. Simply changing the logic to use contains instead of equals should address this, without losing the safety of the check.

Note there are other failures on dev which still exist after applying this change, which I intend to address with another pull request.

[klrmn]

searching for _page_title in this repo leads me to discover there are 3 possible page titles in moztrap:
'Moztrap', 'BrowserID' (from the browserid subproject), and 'Login | MozTrap' (used once). I think that checking the page title for this project is kinda bogus, and doesn't prove anything about what page you're on. on the other hand, this might be a feature request that Moztrap use useful page titles.

[camd]

Funny you should mention this. I just implemented useful page titles in moztrap in 1.3.7 (going on Staging today, likely). Hopefully they're useful, at least. You can check them out on moztrap-dev now, if you like.

[klrmn]

laugh. yes, that would solve it =)

[bobsilverberg]

This is good news because when I was looking at the code for is_the_current_page I thought that it could use a refactor. The code in the page objects contains assertions which I'm not really keen on, although I'm not sure if that can be avoided entirely due to the nature of how the page objects are used. Still, I think it is worth looking at more closely, and that can be done along with an attempt to use the new useful page titles.

I wanted to get the suite passing again, and I still think this pull is worthwhile for that as the is_the_current_page checks will not be any less useful with this change.

I will open an issue to address the refactor and using new page titles.

[bobsilverberg]

I have updated the page objects to use the new titles. The tests are passing on dev but not yet on staging.

[stephendonner]

Thx, Bob; I see the run passing in Jenkins, and the context + comments make this a clear win. r+, merging in.