Update plugin and tests #12

Merged
merged 3 commits into from Aug 2, 2012

Projects

None yet

4 participants

@zacc
Contributor
zacc commented Jul 24, 2012

Updated the plugin to use 1.0 and the test destructive tags.
Also updated tests where the html on mozilla.org has changed.

@klrmn
klrmn commented Jul 31, 2012

LGTM. @stephendonner, if it runs on the farm, i say merge it.

@teodosia teodosia commented on an outdated diff Aug 1, 2012
tests/test_nondestructive.py
@@ -9,7 +9,7 @@
from pages.page_object import MySiteHomePage
-class TestNonDestructive():
+class TestDestructive():
@teodosia
teodosia Aug 1, 2012 Contributor

We should change the name of the file too in order to be in sync with the class name. At the moment the two are in contradiction.

@teodosia teodosia commented on an outdated diff Aug 1, 2012
tests/test_nondestructive.py
@@ -21,5 +21,10 @@ def test_load_baseurl_nondestructive(self, mozwebqa):
home_page.go_to_home_page()
Assert.true(home_page.is_the_current_page)
- def test_that_we_do_something_to_find_a_bug(self, mozwebqa):
+ def test_load_baseurl_destructive(self, mozwebqa):
+ '''
@teodosia
Contributor
teodosia commented Aug 1, 2012

Thanks for the fast update. Lgtm.

@stephendonner
Collaborator

Merging!

@stephendonner stephendonner merged commit 48ec9e7 into mozilla:master Aug 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment