enable proxyDNS only for supported proxies (SOCKS4/5)

mozilla · Apr 19, 2022 · 4d29a19 · 4d29a19
1 parent 26457f4
commit 4d29a19
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/js/background/assignManager.js b/src/js/background/assignManager.js
@@ -197,12 +197,17 @@ window.assignManager = {
       return {};
     }
 
+    // proxyDNS only works for SOCKS proxies
+    if (result.proxy.type === "socks" || result.proxy.type === "socks4" ) {
+        result.proxy.proxyDNS = true
+    }
+
     if (!result.proxy.mozProxyEnabled) {
-      return { ...result.proxy, proxyDNS: true };
+      return result.proxy;
     }
 
     // Let's add the isolation key.
-    return [{ ...result.proxy, connectionIsolationKey: "" + MozillaVPN_Background.isolationKey, proxyDNS: true }];
+    return [{ ...result.proxy, connectionIsolationKey: "" + MozillaVPN_Background.isolationKey }];
   },
 
   // Before a request is handled by the browser we decide if we should