Skip to content

Commit

Permalink
Merge pull request #2428 from dannycolin/radio-hover-css
Browse files Browse the repository at this point in the history
Fix broken radio focus styling in light mode
  • Loading branch information
dannycolin committed Nov 29, 2022
2 parents 00fd9b7 + c4b0823 commit 65a36ee
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 8 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "testpilot-containers",
"title": "Multi-Account Containers",
"description": "Containers helps you keep all the parts of your online life contained in different tabs. Custom labels and color-coded tabs help keep different activities — like online shopping, travel planning, or checking work email — separate.",
"version": "8.1.0",
"version": "8.1.1",
"author": "Andrea Marchesini, Luke Crouch, Lesley Norton, Kendall Werts, Maxx Crawford, Jonathan Kingston",
"bugs": {
"url": "https://github.com/mozilla/multi-account-containers/issues"
Expand Down
23 changes: 17 additions & 6 deletions src/css/popup.css
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,9 @@
--toggle-on-bg-focus-color: #0060df;
--toggle-on-border-color: #0060df;
--toggle-on-handle-bg-color: #fff;
--usercontext-bg-hover-color: #e0e0e6;
--usercontext-bg-active-color: #e0e0e6;
--usercontext-bg-hover-color: #f0f0fa;
--usercontext-bg-focus-color: #e0e0e6;
--usercontext-bg-active-color: #cfcfd8;
--moz-vpn-tout-shadow: 0 0 7px 0 #9498a25e;
}

Expand Down Expand Up @@ -1884,15 +1885,25 @@ manage things like container crud */
margin-inline: auto;
}

/* When focusing the element add a thin blue highlight to match input fields. This gives a distinction to other selected radio items */
.radio-choice > .radio-container > [type="radio"]:focus + label {
outline: solid 1px var(--input-border-focus-color);
-moz-outline-radius: 100%;
}

.radio-choice > .radio-container > [type="radio"]:checked + label {
background-color: var(--usercontext-bg-focus-color);
border-radius: 100%;
}

/* When focusing the element add a thin blue highlight to match input fields. This gives a distinction to other selected radio items */
.radio-choice > .radio-container > [type="radio"]:focus + label {
outline: solid 1px var(--input-border-focus-color);
-moz-outline-radius: 100%;
.radio-choice > .radio-container > [type="radio"]:checked + label:hover {
background-color: var(--usercontext-bg-hover-color);
border-radius: 100%;
}

.radio-choice > .radio-container > [type="radio"]:checked + label:active {
background-color: var(--usercontext-bg-active-color);
border-radius: 100%;
}

.edit-container-panel fieldset {
Expand Down
2 changes: 1 addition & 1 deletion src/manifest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"manifest_version": 2,
"name": "Firefox Multi-Account Containers",
"version": "8.1.0",
"version": "8.1.1",
"incognito": "not_allowed",
"description": "__MSG_extensionDescription__",
"icons": {
Expand Down

0 comments on commit 65a36ee

Please sign in to comment.