Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable and re enable #1082

Closed
kerenbir opened this issue Jan 15, 2018 · 8 comments
Closed

disable and re enable #1082

kerenbir opened this issue Jan 15, 2018 · 8 comments
Labels
bug Something is broken!

Comments

@kerenbir
Copy link

kerenbir commented Jan 15, 2018

this really make me shock i just disable this add onn and re enable again and **** i lost all my container just like new.

@SoftVision-EmilPasca
Copy link

Hy @kerenbir, Thanks for reporting this issue.
Could you please provide more information regarding your environment such as operating system, Firefox version and addons that you have installed? Any other information that you think it may be relevant to this issue could help us investigate this further.

@kerenbir
Copy link
Author

im using windows 10 and firefox version 57.0.4 add ons firefox multi accounts container. i have do nothing im just disable this addons and so enable again and yeah lost i lost all my container.
hope you fix this asap becouse this really make me shock

@SoftVision-EmilPasca
Copy link

SoftVision-EmilPasca commented Jan 16, 2018

I have managed to reproduce the issue on Windows 10 x64, Mac 10.13 and also on Arch Linux (4.12) x64 with the latest Firefox Release(57.0.4) and the latest Firefox Multi-Account Containers (5.0.1).

The issue is not reproducible when testing it with the latest Nightly (59.0a1-20170915220136).

[Additional Notes]:

  • Attached a screen recording of the issue:
    containers_enable_disable_issue

@SoftVision-EmilPasca SoftVision-EmilPasca added the bug Something is broken! label Jan 16, 2018
@kerenbir
Copy link
Author

yeah the question is where is container #1 you just make?

@kerenbir
Copy link
Author

container #1

@kerenbir
Copy link
Author

yeah i hope fix this

@groovecoder
Copy link
Member

This may have been by design. (@jonathanKingston?)

IIRC when the add-on is disabled or un-installed, we destroy any data that the add-on created.

Is there already a bug to only destroy the data during uninstall - i.e., don't destroy data during disable ?

@groovecoder
Copy link
Member

Sorry, this is by design. We need to delete container data when the add-on is disabled, in case the user goes on to un-install the add-on completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken!
Projects
None yet
Development

No branches or pull requests

4 participants