Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to close a tab without showing the hidden container. #168

Closed
bakulf opened this issue Feb 10, 2017 · 6 comments · Fixed by #1270
Closed

Add ability to close a tab without showing the hidden container. #168

bakulf opened this issue Feb 10, 2017 · 6 comments · Fixed by #1270
Assignees
@jonathanKingston

Comments

@bakulf
Copy link
Collaborator

bakulf commented Feb 10, 2017

When the user hides tabs, there is not a way to close all of them (or some of them) without showing them all again.
@TanviHacks TanviHacks added needs:Product Needs: UX Needs to be reviewed by the UX team labels Feb 11, 2017
@TanviHacks
Copy link

The list of hidden tabs are grayed out (since they aren't clickable). After discussion in today's containers meeting, we propose that they also have an X on the right hand side of the grayed out lines, so that a user can remove individual tabs that are hidden in a Container.

@johngruen does that sound okay?

@ChenMorpheus
Copy link

If we want to provide users the ability to close tabs within the list, I would recommend not only offering for hidden containers but also visible containers since it is more consistent and usable for both modes. Please find the mockup below for detailed flow and let me know if any questions, thanks.

close hide tabs

@pdehaan pdehaan added this to the Stretch milestone Feb 17, 2017
@TanviHacks TanviHacks modified the milestones: Sprint 1, Stretch Feb 24, 2017
@groovecoder
Copy link
Member

@ChenMorpheus - do we have a specific asset for the close "x" button here?

@TLHuang
Copy link

TLHuang commented Mar 3, 2017 •
edited

Attached the close icon. Please set the opacity on hover state to 50, and set to 100 for the active state. Let me know if any questions.

container-close-tab.zip

@groovecoder
Copy link
Member

Thanks @TLHuang. I'm removing the needs:UX label for now.

@groovecoder groovecoder removed Needs: UX Needs to be reviewed by the UX team needs:Product labels Mar 3, 2017
@groovecoder groovecoder modified the milestones: Stretch, Sprint 1 Mar 3, 2017
@jonathanKingston jonathanKingston changed the title How to close an hidden tab without showing it? Add ability to close a tab without showing the hidden container. Mar 9, 2017
@kjozwiak kjozwiak mentioned this issue Mar 30, 2017
Open
@groovecoder groovecoder removed this from the Stretch milestone Apr 28, 2017
@jonathanKingston jonathanKingston self-assigned this Sep 26, 2017
@ShivangiKakkar
Copy link
Contributor

@bakulf @groovecoder I would love to work on this issue? May I?

@ShivangiKakkar ShivangiKakkar mentioned this issue Sep 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanKingston jonathanKingston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#168, added ability to close a tab individually ShivangiKakkar/multi-account-containers
8 participants
@groovecoder @jonathanKingston @bakulf @pdehaan @TanviHacks @TLHuang @ChenMorpheus @ShivangiKakkar