Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposable (throw-away) Containers #929

Open
girst opened this issue Oct 31, 2017 · 6 comments
Open

Disposable (throw-away) Containers #929

girst opened this issue Oct 31, 2017 · 6 comments
Labels
Status: Good Extra Addon Feature requests out-of-scope for this addon 👍 Feature Request Feature requests users would like to see in this addon

Comments

@girst
Copy link

girst commented Oct 31, 2017

Temporary Containers Addon works well for this purpose!

I'd like to have an option to generate a new temporary container on-the-fly - sort of a private tab instead of a private window. These disposable containers should be destroyed automatically, when the last tab is closed.

This is how I imagine the workflow:

  • right click a link -> Open in New Container Tab -> Disposable Container
  • click tool bar icon -> (+) New Disposable Container

in #429 (closed by the author), the addon Containers on the Go has been mentioned, which seems to implement this feature, but is proprietary software.

@groovecoder groovecoder added the Status: Good Extra Addon Feature requests out-of-scope for this addon label Oct 31, 2017
@groovecoder
Copy link
Member

I'm starting a new label called "good extra addon" for issues like this. We are pointing add-on authors to this repo for ideas for "follow-up" addons that extend on the core MAC add-on.

@Narvey
Copy link

Narvey commented Nov 1, 2017

@groovecoder if that's going to be the model, why not make the core features built-in instead of an addon?

@groovecoder
Copy link
Member

@Narvey that's a good point.

Over the course of the Test Pilot experiment, we learned that Containers is still mostly a power-user feature. Distributing as an add-on works for power users, and it lets us work on the code-base outside of the Firefox release models.

@stoically
Copy link
Member

I'm currently working on a MIT version of Temporary/Throw-away Containers. It lacks any possibility to set personal preferences yet, but I'm planning to add them soon. If you have any suggestions please let me know.

@stoically
Copy link
Member

stoically commented Dec 1, 2017

@groovecoder I've implemented a feature for the Temporary Container Add-on where it'll automatically open tabs in temporary containers when Middle Mouse Clicking (can't preventDefault them in Firefox) on links. Thing is that I have to deal with race-conditions where MAC also wants to reopen the link, either for the confirm page ("always open in $") or directly in the target container ("remember my choice").

It would be nice if there would be a way to interface with MAC to handle these cases sanely. Maybe providing the list of URLs (including the "remember"-choice) when asked by a whitelisted extensionid (runtime.onMessage)? That way I could predict what MAC is going to do (somewhat at least, opening the same link multiple times in quick succession would probably still be tricky). If you have other ideas or suggestions how to handle this I'd absolutely interested to hear them. I could also start to dig into MAC and start with a Pull Request for an interface. Thanks for your work!

Edit: This got implemented with #1095

@grahamperrin
Copy link

Temporary Containers 0.90 with Waterfox 56.2.0:

2018-06-02 03 23 01 waterfox

I understand that there'll be no automated interop with other container-oriented extensions, that's not a concern here.

Stats work:

2018-06-02 04 03 04 waterfox

– and so on.

I don't expect to use advanced features any time soon.

$ pkg info waterfox | grep Version
Version        : 56.2.0.31
$ date ; uname -v
Sat  2 Jun 2018 04:32:53 BST
FreeBSD 12.0-CURRENT #3 r334382: Thu May 31 01:37:12 BST 2018     root@momh167-gjp4-hpelitebook8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Good Extra Addon Feature requests out-of-scope for this addon 👍 Feature Request Feature requests users would like to see in this addon
Projects
None yet
Development

No branches or pull requests

7 participants
@groovecoder @grahamperrin @Narvey @dannycolin @girst @stoically and others