Fix proxy parsing #2557
Open
Fix proxy parsing #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodag
force-pushed
the
fix-proxy-parsing
branch
from
b6e1f9b
to
1ad9d01
Compare
leodag
force-pushed
the
fix-proxy-parsing
branch
from
1ad9d01
to
3bf0313
Compare
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Aug 3, 2023
dannycolin
requested changes
Nov 29, 2023
| @@ -50,6 +50,10 @@ proxifiedContainers = { | |||
| return false; | |||
| } | |||
|
|
|||
| if (!matches.groups.port) { | |||
| matches.groups.port = 1080; | |||
There was a problem hiding this comment.
IIRC, HTTP(S) have a different default port. Since we're accepting both SOCKS and HTTPS, we should also consider this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2556
You'll probably want to apply #2554 too to test this, since otherwise you can't enter ':' (nor Ctrl+v on the field)
If a match for "port" is not found, it can be set as 1080 (the default SOCKS port).
This may have some implications for the following lines. If Mozilla VPN is set, does it matter whether port is set or not?