Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation for a contextmenu item #2634

Merged
merged 1 commit into from Apr 22, 2024
Merged

Conversation

bakulf
Copy link
Collaborator

@bakulf bakulf commented Apr 17, 2024

@@ -764,7 +764,7 @@ window.assignManager = {
async initBookmarksMenu() {
browser.contextMenus.create({
id: this.OPEN_IN_CONTAINER,
title: "Open Bookmark in Container Tab",
title: browser.i18n.getMessage("openBookmarkInContainerTab"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do I see this string? I have the add-on installed, but don't see it in the context menu for bookmarks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In MAC preferences, you need to tick "Enable bookmark menus"

image

  1. Open Firefox sidebar and select the bookmarks view (Ctrl + B).
  2. Right-Click on a bookmark

@dannycolin dannycolin requested a review from flodolo April 22, 2024 00:39
@dannycolin dannycolin merged commit 1537e9f into main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants