Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server active connection list: avoid duplicates #921

Closed
agrover opened this issue Aug 10, 2020 · 2 comments
Closed

Server active connection list: avoid duplicates #921

agrover opened this issue Aug 10, 2020 · 2 comments
Labels
server-side Issue relates more to server-side

Comments

@agrover
Copy link
Contributor

agrover commented Aug 10, 2020

Follow-on to #920, the connection list is a VecDeque. This is good because things put on the list are handled in order, but bad because a single connection can be put on the list multiple times. Either waiting should be some type of collection that doesn't add duplicates (but still returns things in order added?) or we should take care to not add a connection to it, if it's already on the list.

@agrover agrover added the server-side Issue relates more to server-side label Aug 10, 2020
@agrover agrover added this to Needs triage in 2H 2020 bug triage via automation Aug 10, 2020
@agrover agrover moved this from Needs triage to Low priority in 2H 2020 bug triage Aug 10, 2020
mxinden added a commit to mxinden/neqo that referenced this issue Apr 11, 2024
See whether mozilla#921 has any performance impact.
@larseggert
Copy link
Collaborator

@mxinden I think this is OBE with your recent changes?

@mxinden
Copy link
Collaborator

mxinden commented Jul 18, 2024

Yes. Good catch. Thanks.

@mxinden mxinden closed this as completed Jul 18, 2024
2H 2020 bug triage automation moved this from Low priority to Closed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server-side Issue relates more to server-side
Projects
Development

No branches or pull requests

3 participants