-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deduplicate events #1818
Conversation
See whether mozilla#921 has any performance impact.
Benchmark resultsPerformance differences relative to c004359.
Client/server transfer resultsTransfer of 134217728 bytes over loopback.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1818 +/- ##
==========================================
- Coverage 93.13% 93.13% -0.01%
==========================================
Files 117 117
Lines 36353 36346 -7
==========================================
- Hits 33857 33850 -7
Misses 2496 2496 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing any impact. But this seems like a decent change.
Under the assumption that |
For the record, this has been done in #1929. |
See whether #921 has any performance impact.
Though arguably, given that it origins from a
HashSet
and given thecontains
call, there is no duplication.(Calling
dedup
on an unsortedVec
is not complete.)