Fix EOF handling in ne_buffer_read (used by nestegg_sniff). #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any short read would be treated as EOF. Now, EOF is only returned if the entire buffer has been consumed, and any short read is signalled as an error. This matches the expected behaviour of the nestegg_io interface. This code is duplicated in test/fuzz.cc, so also fixed there. This addresses an OOM found by the oss-fuzz project (issue 8875).
|
r? @SingingTree please |
SingingTree
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any short read would be treated as EOF. Now, EOF is only
returned if the entire buffer has been consumed, and any short read is
signalled as an error. This matches the expected behaviour of the
nestegg_io interface.
This code is duplicated in test/fuzz.cc, so also fixed there.
This addresses an OOM found by the oss-fuzz project (issue 8875).