Test suite #9

Pomax · 2016-12-22T23:33:08Z

forming a PR because it lets me actually conveniently comment on tests =)

Pomax · 2016-12-22T23:49:47Z

pulseapi/entries/test_views.py

+            entry.save()
+
+    def test_get_single_entry_data(self):
+        """


we probably want to test for "by title" with two same-titled entries too

Make two entries with the same title and see if we get two entries back.

Pomax · 2016-12-22T23:50:27Z

pulseapi/entries/test_views.py

+        self.assertEqual(response.status_code, 200)
+
+    def test_post_minimum_entry(self):
+        #Entry with minimum amount of content (title, description?)


do we want negative tests, too, so that there's no way to regress to a model where title+description are no longer necessary?

(test for entry missing a title, and one missing a descr., and make sure those are errors)

Pomax · 2016-12-22T23:51:42Z

pulseapi/entries/test_views.py

+    def test_get_tag_list(self):
+        #maybe for another view. But tags list should have multiple tags, some with multiple entries associated
+        #do we need an endpoint for /tags/{tagname} that has the associated entries? or does /entries/?tag=foo work?
+


we probably want an issues list too, since those'll have to be API exposed for 3rd parties (so they can generate an issue dropdown)

Pomax · 2016-12-22T23:52:25Z

pulseapi/entries/test_views.py

+        #test filtering entires by issue
+
+    def test_post_entry_new_issue(self):
+        #posting an entry with a new Issue should result in an error. Permission denied?


probably not permission denied, but maybe a 409 "please rephrase yourself" with a specific JSON response that explains the problem is a non-existent issue?

The current response is 400 that Object with name does not exist. DRF does this on its own, so I'd say let's stick with that?

Pomax · 2016-12-22T23:53:13Z

pulseapi/entries/test_views.py

+        #make sure 5 issues are in the database. Does testing use a "real" database?
+
+    def test_post_authentication_requirement(self):
+        #uhhhh how do we do this?


hmm... can we fake request.session? these might need to be unit tests on the entries and users views.py instead though

Don't authenticate, then try to post.

https://httpstatuses.com/422 looks pretty appropriate

I've ended up attempting to get a nonce as an unauthenticated user. That gives a 404, which is a passing test.

Pomax · 2016-12-22T23:54:00Z

requirements.txt

 google-api-python-client==1.5.5
 httplib2==0.9.2
 oauth2client==4.0.0
 oauthlib==2.0.0
+pyasn1==0.1.9


what keeps adding pyasn.... O_O

(from what I can tell nothing actually needs it, it just gets added for... convenience?)

Collecting pyasn1>=0.1.7 (from oauth2client==4.0.0->-r requirements.txt (line 10)) Downloading pyasn1-0.1.9-py2.py3-none-any.whl Collecting pyasn1-modules>=0.0.5 (from oauth2client==4.0.0->-r requirements.txt (line 10)) Downloading pyasn1_modules-0.0.8-py2.py3-none-any.whl

Pomax · 2016-12-23T00:28:49Z

pulseapi/entries/test_views.py

+        #posting an entry with a new Issue should result in an error. Permission denied?
+
+    def test_check_for_issues(self):
+        #make sure 5 issues are in the database. Does testing use a "real" database?


it uses the real database, but we may need to verify it uses django.test so that tests on the db happen as transactions (i.e. properly independent)

Not sure I follow this. To rephrase my original comment though, I was hoping the migrations from the original issue generation would be in there. It looks like they are, as writing this test was trivial.

And posting tags, creators from sample form.

alanmoo · 2017-01-05T20:11:42Z

I don't think I can request you to review this since you opened it @Pomax but I think it's ready.

alanmoo · 2017-01-05T20:14:36Z

(Though I realize I didn't implement some of the things from your comments. Digging into those now)

Pomax · 2017-01-09T17:49:12Z

pulseapi/creators/models.py

 class Creator(models.Model):
    """
-    A pulse entry
+    Person responsible for doing the thing an entry is about


"Person recognized as the creator of the thing an entry links out to"?

Pomax · 2017-01-09T17:57:11Z

pulseapi/creators/tests.py

+            'internal_notes': 'Some internal notes'
+        })
+        creatorList = json.loads(str(self.client.get('/creators/?search=A').content, 'utf-8'))
+        self.assertEqual(creatorList, ['Alan'])


why does github even care about this?

Truly a question I've wondered for a while now

Pomax · 2017-01-09T17:58:02Z

pulseapi/entries/serializers.py

@@ -39,6 +42,9 @@ class EntrySerializer(serializers.ModelSerializer):
    issues = serializers.SlugRelatedField(many=True,
                                          slug_field='name',
                                          queryset=Issue.objects)
+    creators = CreatableSlugRelatedField(many=True,
+                                            slug_field='name',


nit: indent looks off, no idea if PEP8 has opinions here

Pomax

I guess these are comments now...

Pomax · 2017-01-09T18:09:36Z

pulseapi/entries/test_models.py

+
+class EntryFactory(factory.DjangoModelFactory):
+
+    # def __init__(self, tags=['foo','bar']):


there's a bit of commenting in this file that we can probably clean up.

Pomax · 2017-01-09T18:10:43Z

pulseapi/entries/test_views.py

+
+class TestEntryView(TestCase):
+    def setUp(self):
+        self.entries = [EntryFactory() for i in range(2)]


Hmmmm this looks identical to the code in creators - worth DRYing out?

Pomax · 2017-01-09T18:11:42Z

pulseapi/entries/test_views.py

+
+        values = json.loads(str(self.client.get('/nonce/').content, 'utf-8'))
+        # Set up with some curated data for all tests to use
+        postresponse = self.client.post('/entries/', data={


we should probably capture this data object, and then for each test copy it and modify as needed.

Pomax · 2017-01-09T18:13:15Z

pulseapi/users/test_views.py

+        for user in self.users:
+            user.save()
+
+    # def test_list_users_returns_user_data(self):


are these bad tests?

I'm not sure where these came from, but yeah I don't think they're useful. Removing.

Pomax · 2017-01-09T18:13:30Z

requirements.txt

 google-api-python-client==1.5.5
 httplib2==0.9.2
 oauth2client==4.0.0
 oauthlib==2.0.0
+pyasn1==0.1.9


alanmoo · 2017-01-10T18:17:49Z

Ok, I've updated this branch @Pomax. Take another look?

Pomax · 2017-01-10T22:49:15Z

R+, lets merge this in

Fumbling through tests

d6c8b74

Pomax commented Dec 22, 2016

View reviewed changes

Pomax commented Dec 23, 2016

View reviewed changes

Pomax requested a review from alanmoo December 23, 2016 17:48

Basic test authentication works

6d3f359

alanmoo force-pushed the alan_tests branch from e61819b to 6d3f359 Compare December 23, 2016 20:28

alanmoo added 2 commits January 4, 2017 17:30

Got tests working

2c6c402

And posting tags, creators from sample form.

First test suite complete

6f6a56e

alanmoo changed the title ~~WIP - Fumbling through tests~~ Test suite Jan 5, 2017

alanmoo removed their request for review January 5, 2017 20:11

alanmoo assigned Pomax Jan 5, 2017

Clean up and refactor tests a bit

c27cfdc

alanmoo force-pushed the alan_tests branch from 7df781b to c27cfdc Compare January 5, 2017 22:28

alanmoo had a problem deploying to network-pulse-api-staging January 6, 2017 19:04 Failure

xmatthewx mentioned this pull request Jan 9, 2017

Pulse v2 launch meta mozilla/network-pulse#294

Closed

Pomax commented Jan 9, 2017

View reviewed changes

Refactor tests and clean up

8fccdf3

alanmoo had a problem deploying to network-pulse-api-staging January 10, 2017 18:17 Failure

Pomax merged commit 543e1bb into master Jan 10, 2017

Pomax deleted the alan_tests branch January 10, 2017 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test suite #9

Test suite #9

Pomax commented Dec 22, 2016

Pomax Dec 22, 2016

alanmoo Dec 23, 2016

Pomax Dec 22, 2016 •

edited

Loading

Pomax Dec 22, 2016

Pomax Dec 22, 2016

alanmoo Jan 5, 2017

Pomax Dec 22, 2016

alanmoo Dec 23, 2016

Pomax Dec 23, 2016

alanmoo Jan 5, 2017

Pomax Dec 22, 2016

alanmoo Jan 5, 2017

Pomax Jan 9, 2017

Pomax Dec 23, 2016

alanmoo Jan 5, 2017

alanmoo commented Jan 5, 2017

alanmoo commented Jan 5, 2017

Pomax Jan 9, 2017

Pomax Jan 9, 2017

alanmoo Jan 9, 2017

Pomax Jan 9, 2017

Pomax left a comment

Pomax Jan 9, 2017

Pomax Jan 9, 2017

Pomax Jan 9, 2017

Pomax Jan 9, 2017

alanmoo Jan 10, 2017

Pomax Jan 9, 2017

alanmoo commented Jan 10, 2017

Pomax commented Jan 10, 2017


		class EntryFactory(factory.DjangoModelFactory):

		# def __init__(self, tags=['foo','bar']):

Test suite #9

Test suite #9

Conversation

Pomax commented Dec 22, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pomax Dec 22, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alanmoo commented Jan 5, 2017

alanmoo commented Jan 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pomax left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alanmoo commented Jan 10, 2017

Pomax commented Jan 10, 2017

Pomax Dec 22, 2016 •

edited

Loading