Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap optipng-bin for imagemin-optipng #1181

Closed
mmmavis opened this issue Dec 4, 2019 · 3 comments
Closed

Swap optipng-bin for imagemin-optipng #1181

mmmavis opened this issue Dec 4, 2019 · 3 comments
Labels
blocked ❌ Blocked engineering
Milestone
Icebox

Comments

@mmmavis
Copy link
Member

mmmavis commented Dec 4, 2019 •
edited by Pomax
Loading

As suggested by @Pomax in #1173 (comment), let's swap optipng-bin for imagemin-optipng

Screen Shot 2019-12-03 at 4 42 08 PM
@mmmavis mmmavis changed the title Swap optipng-bin for imagemin-optipng Swap optipng-bin for imagemin-optipng Dec 4, 2019
@mmmavis mmmavis mentioned this issue Dec 4, 2019
Merged
@cadecairos cadecairos added this to the Mar 9 milestone Feb 25, 2020
@Pomax Pomax self-assigned this Feb 25, 2020
@cadecairos cadecairos modified the milestones: Mar 9, Mar 23 Mar 5, 2020
@cadecairos cadecairos modified the milestones: Mar 23, Apr 6 Mar 24, 2020
@Pomax
Copy link
Contributor

Pomax commented Mar 24, 2020

After trying to switch to imagemin, it turns out that it cannot preserve dir structure, so I've filed imagemin/imagemin#348 and this work is effectively blocked until they fix that.

@Pomax
Copy link
Contributor

Pomax commented Apr 2, 2020

shelving until there's some sign that imagemin is actually maintained. We may have to move off of this entirely and go for a cross-platform png optimizer utility instead.

@Pomax Pomax modified the milestones: Apr 6, Icebox Apr 2, 2020
@Pomax Pomax removed their assignment May 27, 2020
@jamilasnell
Copy link

Closing this until we decide to work on pulse again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked ❌ Blocked engineering
Projects
None yet
Milestone
Icebox
Development

No branches or pull requests
4 participants
@Pomax @cadecairos @mmmavis @jamilasnell