Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'browserlist', 'optipng-bin', and 'postcss-cli' to latest version #1173

Merged
merged 5 commits into from
Dec 4, 2019
Merged

Update 'browserlist', 'optipng-bin', and 'postcss-cli' to latest version #1173

merged 5 commits into from
Dec 4, 2019

Conversation

mmmavis
Copy link
Member

@mmmavis mmmavis commented Nov 28, 2019 •
edited
Loading

Related to #1159

@cadecairos cadecairos temporarily deployed to network-pulse-staging-pr-1173 November 28, 2019 20:04 Inactive
mmmavis
mmmavis commented Nov 28, 2019
View reviewed changes
package.json
@@ -80,7 +80,7 @@
"babel-loader": "^7.1.5",
"babel-preset-es2015": "^6.24.1",
"babel-preset-react": "^6.24.1",
"browserslist": "^3.2.6",
"browserslist": "^4.7.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/browserslist/browserslist/blob/master/CHANGELOG.md no breaking changes

mmmavis
mmmavis commented Nov 28, 2019
View reviewed changes
package.json
@@ -64,7 +64,7 @@
"eslint-config-prettier": "^6.6.0",
"eslint-plugin-prettier": "^3.1.1",
"eslint-plugin-react": "^7.16.0",
"optipng-bin": "^5.1.0",
"optipng-bin": "^6.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/imagemin/optipng-bin/releases/tag/v6.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the main readme on https://github.com/imagemin/optipng-bin, we should swap this one out for https://github.com/imagemin/imagemin-optipng rather than updating the version number

@mmmavis mmmavis temporarily deployed to network-pulse-staging-pr-1173 November 28, 2019 20:11 Inactive
mmmavis
mmmavis commented Nov 28, 2019
View reviewed changes
package.json Outdated
@@ -94,7 +94,7 @@
"moment": "^2.24.0",
"node-sass": "^4.12.0",
"npm-run-all": "^4.1.5",
"postcss-cli-simple": "^1.0.3",
"postcss-cli-simple": "^3.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pirxpilot/postcss-cli/releases/tag/3.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, given this is getting less than 200 installs a week (https://www.npmjs.com/package/postcss-cli-simple) should we be using the official https://www.npmjs.com/package/postcss-cli instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I thought about that as well but I couldn't decide if we needed the full package (vs the "simple" version). Will update the PR to replace postcass-cli-simple with postcass-cli.

@mmmavis mmmavis changed the title (WIP) Update 'browserlist' and 'optipng-bin' to latest version (WIP) Update 'browserlist', 'optipng-bin', and 'postcss-cli-simple' to latest version Dec 2, 2019
@mmmavis mmmavis mentioned this pull request Dec 2, 2019
Closed
36 tasks
@mmmavis mmmavis changed the title (WIP) Update 'browserlist', 'optipng-bin', and 'postcss-cli-simple' to latest version Update 'browserlist', 'optipng-bin', and 'postcss-cli-simple' to latest version Dec 2, 2019
@mmmavis mmmavis requested a review from Pomax December 2, 2019 20:07
Pomax
Pomax previously requested changes Dec 2, 2019
View reviewed changes
package.json
@@ -64,7 +64,7 @@
"eslint-config-prettier": "^6.6.0",
"eslint-plugin-prettier": "^3.1.1",
"eslint-plugin-react": "^7.16.0",
"optipng-bin": "^5.1.0",
"optipng-bin": "^6.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the main readme on https://github.com/imagemin/optipng-bin, we should swap this one out for https://github.com/imagemin/imagemin-optipng rather than updating the version number

package.json Outdated
@@ -94,7 +94,7 @@
"moment": "^2.24.0",
"node-sass": "^4.12.0",
"npm-run-all": "^4.1.5",
"postcss-cli-simple": "^1.0.3",
"postcss-cli-simple": "^3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, given this is getting less than 200 installs a week (https://www.npmjs.com/package/postcss-cli-simple) should we be using the official https://www.npmjs.com/package/postcss-cli instead?

@cadecairos cadecairos temporarily deployed to network-pulse-staging-pr-1173 December 3, 2019 00:52 Inactive
@mmmavis mmmavis changed the title Update 'browserlist', 'optipng-bin', and 'postcss-cli-simple' to latest version Update 'browserlist', 'optipng-bin', and 'postcss-cli' to latest version Dec 3, 2019
@mmmavis mmmavis requested a review from Pomax December 3, 2019 01:21
@mmmavis
Copy link
Member Author

mmmavis commented Dec 3, 2019

@Pomax PR updated!

@Pomax
Copy link
Contributor

Pomax commented Dec 4, 2019 •
edited
Loading

@mmmavis do we want to swap optipng-bin for imagemin-optipng in this PR, too, or should that be a separate issue?

Screen Shot 2019-12-03 at 4 42 08 PM

@mmmavis
Copy link
Member Author

mmmavis commented Dec 4, 2019 •
edited
Loading

@Pomax I've filed a new ticket for it (#1181). Let's get this PR merged first as it can unblock my other package update work. 😁

@mmmavis mmmavis mentioned this pull request Dec 4, 2019
Closed
@mmmavis mmmavis merged commit aa8fb70 into master Dec 4, 2019
@mmmavis mmmavis deleted the update-some-npm-packages branch December 6, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pomax Pomax Pomax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmmavis @Pomax @cadecairos