Anonymize nightly and nightlyApp implementations to allow Components.* (Cc, Cu, ...) shortcuts be used

[xabolcs]

From pull #82 for issue #52:

whimboo wrote:

We have an inconsistency here how we use Cc and Ci regarding their short and long names. If you feel fine please make it shorter here.

xabolcs wrote:

I see no inconsistency here reagrding to Cx shortcuts.
Please note that nightly.js doesn't have those shortcuts!

My proposal is that to implement nightly and nightlyApp as anonymous functions,
and export the defined variable to window like below:

(function() {
  const {Cc: classes, Ci: interfaces, Cu: utils, Cm: manager} = Components;

  var nightly = {

    variables: {
      _appInfo: null,
      get appInfo() {...}
    },

  ...
  }

  window.nightly = nightly;
  window.addEventListener("load", nightly.init, false);
  window.addEventListener("unload", nightly.unload, false);

})();

[whimboo]

Why would we need the anonymous function, and don't simply put the const line at the top of the file?

[xabolcs]

... and don't simply put the const line at the top of the file?

To avoid global namespace pollution and other issues.

[whimboo]

I would love to have a restartless extension and that we could make use of require(). :S

[xabolcs]

I would love to have a restartless extension and that we could make use of require(). :S

I happily continue (and publish) my experiments with OverlayManager after we get all my currently open pulls merged:

• screenshot upload
• pastebin
• titlebar customization for SeaMonkey
• AppMenu overlay for Thunderbird
• variables support for TabGroup
• ...

[whimboo]

This only worked for the old legacy extension.