Stricter linting and enforcing #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madarche
changed the title
|
@zaach could you merge this PR too please? Thank you! |
|
@vladikoff since you're around, could you check this one too please? Thanks. |
| @@ -293,6 +293,8 @@ function coerce(k, v, schema, instance) { | |||
| v = moment.duration(parseInt(split[0], 10), split[1]).valueOf(); | |||
| } | |||
| break; | |||
| default: | |||
| // TODO: Should we throw an exception here? | |||
There was a problem hiding this comment.
I guess we can fix that in the future?
There was a problem hiding this comment.
Right, I didn't want to modify the behavior with this commit, I just wanted to set up "protections" for future commits. The fix for the TODO should be done in another later commit.
vladikoff
added a commit
that referenced
this pull request
Jan 30, 2016
Stricter linting and enforcing
|
Thanks again @vladikoff! |
|
@madarche no, thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.