Skip to content

Commit

Permalink
Bug 1325409: Remove unnecessary cleanup.
Browse files Browse the repository at this point in the history
Cleanup is already run when the notification is removed, so calling it
in close() causes it to be called twice. Also, when the notification
is removed, it sends a Heartbeat event, which fails if cleanup has
already happened.
  • Loading branch information
Michael Kelly committed Jan 23, 2017
1 parent 15dc251 commit 5816fbc
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion recipe-client-addon/lib/Heartbeat.jsm
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ this.Heartbeat = class {

close() {
this.notificationBox.removeNotification(this.notice);
this.cleanup();
}

cleanup() {
Expand Down

0 comments on commit 5816fbc

Please sign in to comment.