Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind RecipeForm.changeAction to the class instance. #239

Merged
merged 1 commit into from
Aug 29, 2016

Conversation

Osmose
Copy link
Contributor

@Osmose Osmose commented Aug 28, 2016

I noticed locally that the recipe form wasn't showing the action forms when I changed the action when creating a new recipe, and tracked it down to not binding this function properly. The dev server doesn't have this problem, weirdly. Not sure why I'm only seeing it locally.

I wanted to create a test for this, but the right test IMO is to test that the console-log form is shown when changing the select box via a user interaction, and we don't really have a great setup yet for running those kind of tests. It's also awkward to this via unit tests because the component as written is generic, so a test that relies specifically on console-log seems to not fit the unit tests for the component.

I'm open to feedback on better ways to test this. Otherwise, r?

@brittanydionigi brittanydionigi self-assigned this Aug 29, 2016
@brittanydionigi
Copy link
Contributor

r+

I believe I have some local branch with WIP tests for this kind of interaction. I will push and PR what I had started and continue the conversation there.

@brittanydionigi brittanydionigi merged commit 054df76 into mozilla:master Aug 29, 2016
@Osmose Osmose deleted the changeform-bind branch October 1, 2016 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants