Fix #469: Use extra_filter_expression as name for filter expressions. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssions. Updates the frontend to match the field name for the backend.
|
I'm stealing this review to keep things moving today. |
mythmon
approved these changes
Feb 2, 2017
There was a problem hiding this comment.
I was able to reproduce the problem I saw on prod locally on master. With this patch the problem goes away. (all while running webpack --watch).
I grepped for [^_]filter_expression, and all of the instances I saw were related to execution of recipes, where it is correct to read the compiled expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the frontend to match the field name for the backend.
I ran into this error yesterday and wrote a fix, but this morning I tried replicating the issue on master and couldn't anymore, and assumed I had some stale JS builds or something. But then #469 happened, so I'm not sure anymore.
I think it's important that we reliably replicate this locally before testing and merging this fix.