API, ControlApp Actions refactor #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rehandalal
force-pushed
the
api-refactor
branch
from
dd41b51
to
b5adba2
Compare
chartjes
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControlActionsandControlAppReducercontrol/apidirectory , andmakeApiRequesthas been moved tocontrol/api/index.js. Essentially, all the API handling/config functions are housed in this dir to make things a little clearer.ControlActionsto their proper files (e.g. notification actions are now inNotificationActions, recipe actions are inRecipeActions, etc)test_ControlAppReducerhad notification tests, recipe tests, etc)This should be an easy review - it's a lot of renaming and restructuring more than actually writing new code.