Upgrade Django to 1.11 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also upgrade a number of other dependencies * Import RNA into Nucleus and remove as a dep * Add pyup filters for Django and django-filter Fix mozilla#40
jpetto
approved these changes
Oct 5, 2018
There was a problem hiding this comment.
Don't see any issues with the code. 🙌
Only question I have is - do we need jquery-2.1.1.js and react.js? I see we also have the minified versions here, and afaict, those are the ones loaded into the templates. Maybe they've been kept around for easier debugging during local dev?
|
We may well not need both of those. I'm honestly not sure. We should follow up on that. |
|
Thanks Jon! I'm going to go ahead and merge this then so it can deploy to dev and we can further test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40