Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix browser tests, close#612 #628

Merged
merged 1 commit into from
Jan 6, 2016
Merged

Conversation

oyyd
Copy link
Contributor

@oyyd oyyd commented Jan 5, 2016

Due to attempt to modify read-only property length -- see http://mozilla.github.io/nunjucks/files/tests/browser/

It's the problem of expect.js so that I have updated the newest version in /tests/browser.

I also updated the newset version of mocha in /tests/browser as it will cause a timeout failure in browsers.

But there are still two failing tests related to ignore missing which was not tested in browsers before and I don know how to do with them.

@carljm
Copy link
Contributor

carljm commented Jan 6, 2016

Thank you! This is a great pull request, much appreciated.

The ignore missing tests are failing because the WebLoader throws an error instead of returning null on a missing template. I'll merge this and then fix that separately.

carljm added a commit that referenced this pull request Jan 6, 2016
Try to fix browser tests, close #612
@carljm carljm merged commit 74c2e71 into mozilla:master Jan 6, 2016
@carljm
Copy link
Contributor

carljm commented Jan 6, 2016

FYI I fixed the WebLoader issue and pushed v2.3.0, and the online docs now have passing tests: http://mozilla.github.io/nunjucks/files/tests/browser/

Thanks again!

@oyyd
Copy link
Contributor Author

oyyd commented Jan 7, 2016

@carljm 👍 Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants