Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Issue 7: Add more stub files for a more realistic site structure #130

Merged
merged 1 commit into from
Nov 4, 2015

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 2, 2015

Adding some stub files that many applications use.

@darkwing darkwing changed the title (WIP) Issue 7: Add more stub files for a more realistic site structure Issue 7: Add more stub files for a more realistic site structure Nov 3, 2015
@darkwing darkwing force-pushed the 7-template-app-files branch 2 times, most recently from c3665ee to 17dcf15 Compare November 3, 2015 15:14
@darkwing
Copy link
Contributor Author

darkwing commented Nov 3, 2015

Let me know what you think of this. I've not added fonts to the repo, instead using Mozilla's CDN as requested by Tabzilla.

@marco-c
Copy link
Contributor

marco-c commented Nov 3, 2015

Maybe we can add style/ and fonts/ directories as well?

We should add these files to the template app though, not to the oghliner app.

@darkwing
Copy link
Contributor Author

darkwing commented Nov 3, 2015

Updated!

@marco-c
Copy link
Contributor

marco-c commented Nov 3, 2015

The file favicon.ico is duplicated (app/favicon.ico and app/images/favicon.ico)

@darkwing darkwing force-pushed the 7-template-app-files branch 3 times, most recently from 000bfb3 to d8bdc77 Compare November 3, 2015 19:54
@darkwing
Copy link
Contributor Author

darkwing commented Nov 3, 2015

All updates made!

@marco-c marco-c self-assigned this Nov 3, 2015
marco-c added a commit that referenced this pull request Nov 4, 2015
Issue 7: Add more stub files for a more realistic site structure
@marco-c marco-c merged commit f67b669 into mozilla:master Nov 4, 2015
@marco-c
Copy link
Contributor

marco-c commented Nov 4, 2015

For future reference, you can make issues automatically close with particular keywords in the commit message or the pull request:
https://help.github.com/articles/closing-issues-via-commit-messages/
https://github.com/blog/1506-closing-issues-via-pull-requests/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants