ADI export script (bug 1014752) #115
Conversation
magopian
changed the title
| def handle(self, *args, **options): | ||
| start = datetime.now() # Measure the time it takes to run the script. | ||
| day = options['date'] | ||
| if day is None: |
There was a problem hiding this comment.
Can't we default to the date we will be using (I guess "yesterday")?
There was a problem hiding this comment.
I prefer to be explicit on that one given the amount of time/resource it will consume.
|
General note: we should consider doing a PR to pysh2 for the yieldcursor thing. It's worth it in IMHO as we are now adding it as a AMO dependency. |
|
The PR for pyhs2 already exists: BradRuderman/pyhs2#17 |
| raise CommandError('Please specify at least one of --with-updates ' | ||
| 'or --with-downloads.') | ||
|
|
||
| with ClevererConnection(host='peach-gw.peach.metrics.scl3.mozilla.com', |
There was a problem hiding this comment.
no need to obfuscate those credentials with a os.environ.get() or something like that?
There was a problem hiding this comment.
Those are only accessible through the vpn, so I believe this is ok, please let us know if it isn't the case @jasonthomas
| app_os, locale, update_type = splitted | ||
| try: | ||
| counter = int(counter) | ||
| except ValueError: # Badly formatted? Drop. |
There was a problem hiding this comment.
Maybe we wanna log this king of skip? In case we have some counter weirdness once in prod, this may help.
ADI export script (bug 1014752)
Fixes bug 1014752