This repository has been archived by the owner on Aug 22, 2019. It is now read-only.
Express 3 and nunjucks on dev #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to push forward with this while @brianloveswords is away. I think it makes things better, but it's a big change so the longer it sits the harder it is to merge. Plus I don't want to keep adding to an already bloated pull as I continue to work.
|
stenington
added a commit
that referenced
this pull request
Nov 20, 2012
Express 3 and nunjucks on dev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the dev branch to express 3 and nunjucks.
Hard to do in small steps, so unfortunately the diffs are a bit insane. I would suggest some solid QA before moving this to production.
Also, there's currently no solution in place to use the dev version of nunjucks in dev and precompiled templates in production.
@brianloveswords Are you comfortable merging this and continuing to improve, or do you want a cleaner pull request?