Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Fix up dependency #926

Merged
merged 2 commits into from Sep 23, 2013
Merged

Fix up dependency #926

merged 2 commits into from Sep 23, 2013

Conversation

brianloveswords
Copy link
Contributor

Fixes #925

I just found out (because of an error in openbadger) that up was unpublished and republished as up-time and that something completely different was published at up. So this fixes that. Needless to say, I'm super happy that happened and that they did that.

Also, up-time has been marked as deprecated so at some point we should just completely remove it as a dependency and figure out something else for code reloading.

@kayaelle
Copy link

Hey Brian,

We've been looking at forever. What are your thoughts on it?

Thanks,

k

On Sep 18, 2013, at 8:56 AM, Brian J Brennan wrote:

I just found out (because of an error in openbadger) that up was unpublished and republished as up-time and that something completely different was published at up. So this fixes that. Needless to say, I'm super happy that happened and that they did that.

Also, up-time has been marked as deprecated so at some point we should just completely remove it as a dependency and figure out something else for code reloading.

You can merge this Pull Request by running

git pull https://github.com/brianloveswords/openbadges 925-fix-up
Or view, comment on, or merge it at:

#926

Commit Summary

Fix up dependency
File Changes

M package.json (2)
Patch Links:

https://github.com/mozilla/openbadges/pull/926.patch
https://github.com/mozilla/openbadges/pull/926.diff


Kerri Lemoie
CODERY
Co-Founder & Chief Web Technologist
www.GoCodery.com
Digital Badges Solutions Provider
@GoCodery @kayaelle

@brianloveswords
Copy link
Contributor Author

@kayaelle I haven't tried it too much. It'll more than likely be fine for development, though. I was probably gonna check out node-supervisor by isaacs which is a little simpler and fine for just doing code watching/reloading, which is all we need here.

@cmcavoy
Copy link
Contributor

cmcavoy commented Sep 18, 2013

Ha, yeah, was wondering about that. I was worried we were using the new up for something and the old up was...Meh any who, good work detective.

@stenington
Copy link
Contributor

Heh, this is in the statsd PR as 80ed072 as well.

stenington added a commit that referenced this pull request Sep 23, 2013
@stenington stenington merged commit 3aee1ac into mozilla:development Sep 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants