In GENERIC builds, dispatch a "webviewerloaded" event (from the webViewerLoad function) before initializing the viewer
#10318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` with a `disablePreferences`, in `GENERIC` builds, `AppOption instead Rather than having a (somewhat) randomly choosen list of Preferences which `AppOptions` are allowed to override, it makes much more sense to simply add an AppOption to allow custom implementations to ignore Preferences altogether (it's also inline with the AppOption that allows the `ViewHistory` to be bypassed on load).
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f717837fd8c65cf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f717837fd8c65cf/output.txt Total script time: 2.20 mins Published |
…bViewerLoad` function) before initializing the viewer With the removal of the global `PDFJS` object, in PDF.js version `2.0`, the viewer options are no longer as easily accessible as they previously were (and issues have been filed about this). In particular, since the viewer files aren't necessarily loaded *immediately*, this means that `PDFViewerApplication`/`PDFViewerApplicationOptions` aren't necessarily available directly. By dispatching an event once all viewer files are loaded but *before* the viewer initialization has run, setting `AppOptions` during load (in custom implementations of the default viewer) should hopefully become a little bit easier[1]. --- [1] In hindsight, this should probably have been implemented when the global `PDFJS` object was removed...
Snuffleupagus
force-pushed
the
disablePreferences
branch
from
0ef08f9
to
0dc995c
Compare
Snuffleupagus
changed the title
GENERIC builds, dispatch a "webviewerload" event (from the corresponding function) before initializing the viewerGENERIC builds, dispatch a "webviewerloaded" event (from the webViewerLoad function) before initializing the viewer
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/20bc7b7f0849a1e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/20bc7b7f0849a1e/output.txt Total script time: 2.13 mins Published |
timvandermeij
approved these changes
Nov 30, 2018
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
OVERRIDESlist inPDFViewerApplication._readPreferenceswith adisablePreferences, inGENERICbuilds, `AppOption insteadRather than having a (somewhat) randomly choosen list of Preferences which
AppOptionsare allowed to override, it makes much more sense to simply add an AppOption to allow custom implementations to ignore Preferences altogether (it's also inline with the AppOption that allows theViewHistoryto be bypassed on load).In
GENERICbuilds, dispatch a "webviewerloaded" event (from thewebViewerLoadfunction) before initializing the viewerWith the removal of the global
PDFJSobject, in PDF.js version2.0, the viewer options are no longer as easily accessible as they previously were (and issues have been filed about this).In particular, since the viewer files aren't necessarily loaded immediately, this means that
PDFViewerApplication/PDFViewerApplicationOptionsaren't necessarily available directly. By dispatching an event once all viewer files are loaded but before the viewer initialization has run, settingAppOptionsduring load (in custom implementations of the default viewer) should hopefully become a little bit easier[1]./cc @timvandermeij
[1] In hindsight, this should probably have been implemented when the global
PDFJSobject was removed...