Move more code/methods into BaseViewer, and simplify the PDFSinglePageViewer._scrollIntoView method slightly
#10489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classes override/extend methods as necessary This attempts to provide more "default" methods in the base class, in order to reduce unnecessary duplication and to improve self-documentation of the `BaseViewer` class slightly. The following changes are made (in no particular order): - Have `BaseViewer` implement the `_scrollIntoView` method, and *extend* it as necessary in `PDFViewer`/`PDFSinglePageViewer`. - Simply inline the `BaseViewer._resizeBuffer` method, in `BaseViewer.update`, since there's only one call-site at this point. - Provide a default implementation of `_isScrollModeHorizontal` in `BaseViewer`, and have `PDFSinglePageViewer` override it. - Provide a default implementation of `_getVisiblePages`, and have `PDFViewer` extend it and `PDFSinglePageViewer` override it.
…htly, by unconditionally ensuring that rendering always occurs
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d6d33f2e11cc688/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d6d33f2e11cc688/output.txt Total script time: 1.71 mins Published |
timvandermeij
approved these changes
Jan 25, 2019
|
Looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move additional code/methods into
BaseViewerand have the extending classes override/extend methods as necessaryThis attempts to provide more "default" methods in the base class, in order to reduce unnecessary duplication and to improve self-documentation of the
BaseViewerclass slightly.The following changes are made (in no particular order):
BaseViewerimplement the_scrollIntoViewmethod, and extend it as necessary inPDFViewer/PDFSinglePageViewer.BaseViewer._resizeBuffermethod, inBaseViewer.update, since there's only one call-site at this point._isScrollModeHorizontalinBaseViewer, and havePDFSinglePageVieweroverride it._getVisiblePages, and havePDFViewerextend it andPDFSinglePageVieweroverride it.Try to simplify the
PDFSinglePageViewer._scrollIntoViewmethod slightly, by unconditionally ensuring that rendering always occurs