Prepare the MOZCENTRAL viewer for receiving zoom events from the browser UI (bug 786674, bug 1177385)
#10652
Conversation
|
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9aa500be1df356a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f74ca539f55b9e8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f74ca539f55b9e8/output.txt Total script time: 0.98 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9aa500be1df356a/output.txt Total script time: 2.99 mins
|
|
Unfortunately there isn't really a good way of testing this, short of applying the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=786674#c14 and then building Firefox itself, so I'm hoping that this can be accepted based on its high degree of similarity with the |
Snuffleupagus
force-pushed
the
browser-find-events
branch
from
48a699b
to
a08635a
Compare
There was a problem hiding this comment.
I'm fine with merging this if there is also an upstream reviewer. Perhaps @brendandahl can take a look at the Bugzilla patch, or find someone upstream that can?
Snuffleupagus
force-pushed
the
browser-find-events
branch
2 times, most recently
from
22b0009
to
13a9c21
Compare
…owser UI (bug 786674, bug 1177385) This lays the necessary foundation for handling zoom events originating within the browser itself, rather than in the viewer. Please note that this will also require a follow-up patch to `mozilla-central`, such that the viewer is actually notified when zooming occurs.
Snuffleupagus
force-pushed
the
browser-find-events
branch
from
13a9c21
to
2e044bf
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4ffe6c3fe400854/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4ffe6c3fe400854/output.txt Total script time: 1.86 mins Published |
|
Thank you for the additional explanation! It really cleared up why we're doing this exactly. |
I should probably have included more information upfront, as this wasn't initially in the patch but seemed reasonable to add once I'd done a bit more testing. |
This lays the necessary foundation for handling zoom events originating within the browser itself, rather than in the viewer. Please note that this will also require a follow-up patch to
mozilla-central, such that the viewer is actually notified when zooming occurs. For example something like this: https://gist.github.com/Snuffleupagus/8d27775a3b18f1cd6cac88351edf4f7f