Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Implement caret annotations #10723

Merged
merged 1 commit into from Apr 10, 2019

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Apr 9, 2019

The file test/pdfs/annotation-caret-ink.pdf is already available in the repository as a reference test for this since I supplied it for another patch that implemented ink annotations.

@Snuffleupagus Could you perhaps review this if you have time? I notice that we have quite a bit of open annotation layer patches at the moment and most are too big or incomplete to be actionable, so I'm hoping to find some time later to fix them up. I already made a test file before, but forgot about actually implementing this annotation type and got reminded thanks to one of those patches. This is the first work to get the ball rolling again.

The file `test/pdfs/annotation-caret-ink.pdf` is already available in
the repository as a reference test for this since I supplied it for
another patch that implemented ink annotations.
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2019

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ba662c706a06ed7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/ba662c706a06ed7/output.txt

Total script time: 1.86 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2019

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8ac7b2cfb6c8055/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2019

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/3d4208eaed43b19/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2019

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/8ac7b2cfb6c8055/output.txt

Total script time: 17.91 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/8ac7b2cfb6c8055/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2019

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/3d4208eaed43b19/output.txt

Total script time: 25.94 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/3d4208eaed43b19/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/690bac6b117f935/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/420e2db5574bc50/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/420e2db5574bc50/output.txt

Total script time: 16.22 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/690bac6b117f935/output.txt

Total script time: 22.88 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij merged commit 74561f5 into mozilla:master Apr 10, 2019
@timvandermeij timvandermeij deleted the caret-annotation branch April 10, 2019 22:03
@timvandermeij timvandermeij changed the title Implement caret annotations [api-minor] Implement caret annotations Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants