-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Implement caret annotations #10723
Conversation
The file `test/pdfs/annotation-caret-ink.pdf` is already available in the repository as a reference test for this since I supplied it for another patch that implemented ink annotations.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ba662c706a06ed7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ba662c706a06ed7/output.txt Total script time: 1.86 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8ac7b2cfb6c8055/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3d4208eaed43b19/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8ac7b2cfb6c8055/output.txt Total script time: 17.91 mins
Image differences available at: http://54.67.70.0:8877/8ac7b2cfb6c8055/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/3d4208eaed43b19/output.txt Total script time: 25.94 mins
Image differences available at: http://54.215.176.217:8877/3d4208eaed43b19/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/690bac6b117f935/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/420e2db5574bc50/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/420e2db5574bc50/output.txt Total script time: 16.22 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/690bac6b117f935/output.txt Total script time: 22.88 mins
|
The file
test/pdfs/annotation-caret-ink.pdf
is already available in the repository as a reference test for this since I supplied it for another patch that implemented ink annotations.@Snuffleupagus Could you perhaps review this if you have time? I notice that we have quite a bit of open annotation layer patches at the moment and most are too big or incomplete to be actionable, so I'm hoping to find some time later to fix them up. I already made a test file before, but forgot about actually implementing this annotation type and got reminded thanks to one of those patches. This is the first work to get the ball rolling again.