-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that the OperatorList
constructor actually initializes a NullOptimizer
when intended (PR 9089 follow-up)
#10784
Ensure that the OperatorList
constructor actually initializes a NullOptimizer
when intended (PR 9089 follow-up)
#10784
Conversation
…llOptimizer` when intended (PR 9089 follow-up) It appears that this has been broken ever since PR 9089, which also introduced this code, since the `QueueOptimizer`/`NullOptimizer` choice was made based on the still undefined `this.intent` property. Furthermore, fixing this also uncovered the fact that the `NullOptimizer.reset` method was missing.
/botio-linux lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/540e6aed2e82c55/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/540e6aed2e82c55/output.txt Total script time: 0.97 mins
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b02ecf7b995b2d4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/4ffe07ab6cb8648/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b02ecf7b995b2d4/output.txt Total script time: 17.61 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/4ffe07ab6cb8648/output.txt Total script time: 25.30 mins
|
That's a really good find; thanks! |
It appears that this has been broken ever since PR #9089, which also introduced this code, since the
QueueOptimizer
/NullOptimizer
choice was made based on the still undefinedthis.intent
property.Furthermore, fixing this also uncovered the fact that the
NullOptimizer.reset
method was missing.