Ensure that the OperatorList constructor actually initializes a NullOptimizer when intended (PR 9089 follow-up)
#10784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llOptimizer` when intended (PR 9089 follow-up) It appears that this has been broken ever since PR 9089, which also introduced this code, since the `QueueOptimizer`/`NullOptimizer` choice was made based on the still undefined `this.intent` property. Furthermore, fixing this also uncovered the fact that the `NullOptimizer.reset` method was missing.
|
/botio-linux lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/540e6aed2e82c55/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/540e6aed2e82c55/output.txt Total script time: 0.97 mins
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b02ecf7b995b2d4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/4ffe07ab6cb8648/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b02ecf7b995b2d4/output.txt Total script time: 17.61 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/4ffe07ab6cb8648/output.txt Total script time: 25.30 mins
|
timvandermeij
approved these changes
May 2, 2019
|
That's a really good find; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that this has been broken ever since PR #9089, which also introduced this code, since the
QueueOptimizer/NullOptimizerchoice was made based on the still undefinedthis.intentproperty.Furthermore, fixing this also uncovered the fact that the
NullOptimizer.resetmethod was missing.