[api-minor] Attempt to reduce memory usage during printing, by always running cleanup once rendering has finished
#10879
Conversation
Snuffleupagus
force-pushed
the
print-cleanupAfterRender
branch
2 times, most recently
from
7f0d4b0
to
3ec0ed7
Compare
… running `cleanup` once rendering has finished Given that `cleanupAfterRender` is already set for large images, when handling 'obj' messages, this patch *should* thus be safe in general (since otherwise there ought be existing bugs related to cleanup and printing).
Snuffleupagus
force-pushed
the
print-cleanupAfterRender
branch
from
3ec0ed7
to
625af8d
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b62d6f31a73024f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1a8ab1482e44546/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b62d6f31a73024f/output.txt Total script time: 17.80 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/1a8ab1482e44546/output.txt Total script time: 28.59 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/120f425088ae437/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/120f425088ae437/output.txt Total script time: 1.89 mins Published |
|
Seems to work just fine; thanks! |
Given that
cleanupAfterRenderis already set for large images, when handling 'obj' messages, this patch should thus be safe in general (since otherwise there ought be existing bugs related to cleanup and printing).